18564 Commits

Author SHA1 Message Date
Neethu Haneesha Bingi
83e0368eaa RocksDB increasing background threads to speedup compaction. 2022-03-03 15:14:37 -08:00
Trevor Clinkenbeard
e7a82b68f2
Merge pull request #6486 from sfc-gh-tclinkenbeard/fix-commitlatencybands-sample
Fix name of `ProxyCommitData::commitLatencyBands` sample
2022-03-02 16:24:19 -08:00
sfc-gh-tclinkenbeard
8b2b74980e Fix name of ProxyCommitData::commitLatencyBands sample 2022-03-02 14:57:42 -08:00
Andrew Noyes
9a45df8e6c
Change fdb_c's dep on fdbclient to be private (#6466)
That way transitive dependencies (e.g. libfdb_java.so) don't include
unnecessary fdbclient code. Related: #6455
2022-03-01 18:08:50 -08:00
A.J. Beamon
1ab963eb5b
Merge pull request #6477 from sfc-gh-ajbeamon/trace-overflow-debug-line
Add some extra print debugging if we overflow the trace buffer
2022-03-01 10:12:09 -08:00
Josh Slocum
92a888910f Fix many repeated recruitment bug 2022-03-01 12:00:53 -06:00
A.J. Beamon
beac368ba9 Add a mechanism to enable error backtrace logging for select errors 2022-03-01 09:11:21 -08:00
A.J. Beamon
f6b24cd644 Add some extra print debugging if we overflow the trace buffer. 2022-03-01 09:04:15 -08:00
Renxuan Wang
fa2eee8279 Use PRId64 and PRIu64 to replace lld and llu.
This fixes https://github.com/apple/foundationdb/pull/6148#issuecomment-1054575608.
2022-02-28 21:30:14 -08:00
Xiaoge Su
5e39da7741 fixup! Reformat the source 2022-02-28 18:03:52 -08:00
Xiaoge Su
02e396274f Fix the compile error on NativeAPI.actor.cpp 2022-02-28 18:03:52 -08:00
Zhe Wu
aadd706a0a Port back addressed comments for fixing get key location issue 2022-02-28 16:08:57 -08:00
zhenfeng yang
847cff72b7
Add a target to generate profile (#6396)
add a target to generate profile
2022-02-28 17:00:30 -06:00
Andrew Noyes
2e8bce04c6 Remove brittle fdbcli help text snapshot test
This seems to be more trouble than value so far.
2022-02-28 15:24:29 -06:00
Andrew Noyes
24f37aceb7 Avoid conflict between versioned client/server rpms
Building locally this seems to cause a conflict between the versioned
client and server rpms. Not sure why this doesn't always show up.
2022-02-28 15:24:29 -06:00
Andrew Noyes
d559caefea Use centos:7 for pkg_tester
yum update with just `centos` seems to have problems
2022-02-28 15:24:29 -06:00
Trevor Clinkenbeard
fe957deef8
Merge pull request #6399 from sfc-gh-bvr/fdb#4271
Introduce a new server knob and use it to test if storage servers are…
2022-02-28 13:02:23 -08:00
sfc-gh-tclinkenbeard
90927cffe9 Set disableHostname=true in CycleTestRestart downgrade test 2022-02-26 17:56:56 -08:00
Renxuan Wang
233c918ffb Replace printf() and fprintf() with fmt::print(). 2022-02-25 19:06:57 -08:00
Renxuan Wang
f7eb66441d Try eliminating warnings in macOS and Windows CI builds.
MacOS warnings are format warnings, e.g., `format specifies type 'long' but the argument has type 'Version' (aka 'long long')`.
Windows warnings are `ACTOR does not contain a wait() statement`.
2022-02-25 19:06:57 -08:00
Markus Pilman
079de5ba57 Enable rocksdb unit tests 7.1.0-rc1 2022-02-25 15:38:16 -08:00
Markus Pilman
a61dd41b45 Add an empty test to make sure noSim tests succeed 2022-02-25 15:38:16 -08:00
Andrew Noyes
276cf3a402
Fix minor bugs turned up by _GLIBCXX_DEBUG (#6375)
* Fix a benign bug turned up by _GLIBCXX_DEBUG

Just calling std::vector::operator[] with an out of bounds index at all
is technically undefined behavior.

* Fix compilation issue with _GLIBCXX_DEBUG

For some reason std::max with an initializer list isn't constexpr with
_GLIBCXX_DEBUG set
2022-02-25 13:50:41 -08:00
Andrew Noyes
b58739093e
Account for possibility that fopen might fail in mako (#6442)
Fix an issue in mako where the stats process would hang if the worker process
was unable to open a file. Previously, the worker process would segfault when
trying to dereference a null FILE* and never increment the stopcount variable
in shared memory. Now we check for a null FILE* and increment stopcount when
the worker process stops regardless of success or failure.

Also don't ignore the return value from mkdir
2022-02-25 13:18:59 -08:00
Andrew Noyes
7a9217a392
Add contrib/debug_determinism (#6389)
* Add contrib/debug_determinism

Add an instrumentation-based technique for debugging unseen mismatches. Also guard a few existing sources of nondeterminism that don't affect unseen with the DEBUG_DETERMINISM macro.

Also change the simulated run loop to not run as the only task inside the real run loop, since that was a source of nondeterminism.

Also fix nondeterminism from calling timer_int

* Add StorageMetadataType::currentTime

Basically a deterministic-in-simulation version of timer_int that we can
use instead of timer_int for StorageMetadataType::createdTime
2022-02-25 12:54:31 -08:00
Zhe Wu
57e931b489 Update 6.3.24 release notes 2022-02-25 12:12:17 -08:00
A.J. Beamon
d4e6123971
Merge pull request #6457 from Doxense/fix-6449-windows-build
Fix Windows build broken by #6449
2022-02-25 09:07:20 -08:00
Mohamed Oulmahdi
5b6098b5be Fix Windows build broken by #6449 2022-02-25 16:25:45 +01:00
Renxuan Wang
06b1d06d38 Support hostname in coordinators commands. 2022-02-24 23:02:29 -08:00
Renxuan Wang
70d723f70c Move the construction of ConnectionString in changeQuorumChecker() to coordinatorsCommitActor(). 2022-02-24 23:02:29 -08:00
Renxuan Wang
3e761aef3b Add resetConnectionString() function to ClusterConnectionString. 2022-02-24 23:02:29 -08:00
Renxuan Wang
3a3b44efe2 Fix macOS CI broken by #6449.
foundationdb/fdbserver/CoroFlow.actor.cpp:262:8: error: no member named 'errorUnsuppressed' in 'BaseTraceEvent'
2022-02-24 20:26:13 -08:00
Zhe Wu
0bdae35a2c Address comments and move updateFailedEndpointRefreshTime 2022-02-24 16:35:30 -08:00
Zhe Wu
9c99c59b0c Fix get key location overloading proxies 2022-02-24 16:35:30 -08:00
A.J. Beamon
7275e312d8
Merge pull request #6449 from sfc-gh-ajbeamon/trace-enforce-suppression-order
Enforce that trace event suppression calls happen first when using trace event call chaining
2022-02-24 14:39:08 -08:00
A.J. Beamon
d3be393246 Add comments to BaseTraceEvent and TraceEvent. Also make BaseTraceEvent contstructor protected. 2022-02-24 13:29:44 -08:00
A.J. Beamon
e7d2abd764 Fix formatting issue 2022-02-24 12:28:13 -08:00
A.J. Beamon
250a88e682 Enforce that trace event suppression calls happen first when using trace event call chaining. Fix various instances where we weren't following this requirement. 2022-02-24 12:25:52 -08:00
Aaron Molitor
4ff60db82b Revert "Use full version of fdb to support incompatible release candidates"
This reverts commit f379cf4d05920d00a50501298f02fc5ff429844e.
2022-02-24 11:55:48 -06:00
Leonidas Tsampros
f379cf4d05 Use full version of fdb to support incompatible release candidates 2022-02-24 11:03:42 -06:00
Zhe Wang
541fc171f7
Merge pull request #6409 from kakaiu/log-thread-local-perfcontext-counter
Add RocksDB PerfContextMetrics
2022-02-24 08:43:24 -05:00
Markus Pilman
f1189e5947
Merge pull request #6384 from vikasgupta8/ppc64le_support
added support for ppc64le
2022-02-24 14:31:31 +01:00
Zhe Wang
f14e08a991 addRocksDBPerfContextMetrics 2022-02-23 22:29:07 -05:00
Bharadwaj V.R
8cb554a006 Fix formatting issues in DDTeamCollection.actor.cpp 2022-02-23 10:21:34 -08:00
Bharadwaj V.R
102dcb30c6
Merge branch 'main' into fdb#4271 2022-02-23 10:04:19 -08:00
Ata E Husain Bohra
344a14b010
Update StreamCipher ctx/cipher management to respect determinism (#6427)
* Update StreamCipher ctx/cipher management to respect determinism

StreamCipher keeps record of CipherKeys created
(including globalCipherKey) to ensure the sensitive data gets
ZERO-OUT and not recorded as part of FDB process dump. However,
in current code it is maintained as an unordered_set indexed
by the object itself. Approach adds non determinism given
object pointer based indexing scheme.

Patch addresses the concern by updating the recording to use
a map indexed by UID.
2022-02-22 17:34:29 -08:00
Renxuan Wang
3c1394578b Address comments. 2022-02-22 16:29:59 -08:00
Renxuan Wang
ea8b2bd314 Resolve hostnames synchronously when calling actor is impossible. 2022-02-22 16:29:59 -08:00
Renxuan Wang
622d89b552 Rebase on main.
Since we changed ClusterConnectionString's status flag from boolean to enum in #6422, we need to update this PR correspondingly.
2022-02-22 16:29:59 -08:00
Renxuan Wang
8eb7a10404 Address comments. 2022-02-22 16:29:59 -08:00