26083 Commits

Author SHA1 Message Date
Hao Fu
3158f8b033
Fix hashCode() and equals() for MappedKeyValue (#10170) 2023-05-08 16:54:11 -07:00
Hui Liu
53e68065e7
Support blob manifest backup for fdbbackup cmdline (#10091) 2023-05-08 16:07:22 -07:00
Yanqin Jin
f1e22f9a1e
Account for 'tenant_locked' error in MetaclusterManagementWorkload (#10175)
In MetaclusterManagementWorkload, if we lock a tenant that has already been locked with a different lockId, it's possible that a tenant_locked error is thrown. We need to account for this instead of terminating the test.

Test plan:
Regular simulation and a deterministic reproduction

Branch: https://github.com/sfc-gh-yajin/foundationdb/tree/snow-791039
Commit hash: 7356504723d3c77de501b5683b0a159676c56840
Profile: team
Command: devRetryCorrectnessTest bin/fdbserver -r simulation -f tests/slow/MetaclusterManagement.toml -s 3475230174 -b off --crash --trace_format json
2023-05-08 13:38:05 -07:00
Ankita Kejriwal
63354f68ad
Update knob values for Storage Quota polling intervals (#10154) 2023-05-08 10:06:29 -07:00
Josh Slocum
b5a9997217
adding DBPerTXN blob granule tests (#10095)
* adding DBPerTXN blob granule tests

* fixing comment
2023-05-08 15:43:29 +02:00
Hui Liu
65ed7775fd
Add manifest encryption (#10081) 2023-05-05 14:33:37 -07:00
Xiaoxi Wang
96bb675c87
Fix bug: isEnabled() to !isEnabled() (#10163) 2023-05-05 15:31:34 -04:00
Jingyu Zhou
b844a92c1e
Merge pull request #10143 from neethuhaneesha/paranoidChecks
Rocksdb paranoid file checks knob.
2023-05-05 10:23:06 -07:00
Zhe Wang
3e3ed191b3
audit storage statistic (#10155) 2023-05-05 10:21:24 -07:00
Josh Slocum
a4dffa087a
Adding Simulated HTTP Server and refactoring HTTP code (#10112)
* Adding Simulated HTTP Server and refactoring HTTP code

* fixing formatting

* fixing merge conflicts

* fixing more merge conflicts

* code review feedback

* changing reference counted interface

* more fixes

* fixing ide build i guess
2023-05-05 12:19:17 -05:00
Steve Atherton
fb2fc6a260
Merge pull request #10157 from sfc-gh-satherton/systemkey-overlap
Bug fix, check is supposed to be for overlap, not lack of overlap.
2023-05-04 21:24:12 -07:00
Jingyu Zhou
78434517ff Increase buggified STORAGE_METRICS_SHARD_LIMIT value
The previous buggified value 3 can be the same as key location size, thus
causing splitStorageMetrics() to stuck.
2023-05-04 19:31:43 -07:00
Steve Atherton
d52113e7a3 Bug fix, check is supposed to be for overlap, not lack of overlap. 2023-05-04 18:08:37 -07:00
Josh Slocum
fb950a9c81
adding blob ranges to backup keys to not lose blobbification on restore (#10059) 2023-05-04 13:55:20 -05:00
neethuhaneesha
8b2f3bcfdc Rocksdb paranoid file checks knob. 2023-05-04 11:49:38 -07:00
Marian Dvorsky
394899ce7c
Fix heap use-after-free in validateRangeAgainstServer (#10132)
* Fix heap use-after-free in validateRangeAgainstServer
2023-05-04 11:45:21 -07:00
Xiaoge Su
467b9cdbde If no log file generated, report the stderr of the fdbserver process 2023-05-04 11:01:53 -07:00
Xiaoge Su
17487abb93 Add tag for a cherry-pick 2023-05-04 11:01:53 -07:00
Zhongxing Zhang
34569b0058
Merge pull request #10076 from apple/feature/overallBytesWritten
Enable MovingData to show overall moved bytes rather than just one copy
2023-05-04 10:20:03 -07:00
A.J. Beamon
9d647f827c
Merge pull request #10129 from sfc-gh-ajbeamon/require-reliable-coordinator-quorum
Do not allow changing the coordinators to a set that is unreliable in simulation
2023-05-04 08:18:29 -07:00
A.J. Beamon
589b95f821
Merge pull request #10126 from sfc-gh-ajbeamon/api-version-used-during-commit-default-option
Add API version protection to Java's used during commit option
2023-05-03 19:54:39 -07:00
Ankita Kejriwal
cdef4523aa
Update a few Data Distribution code probes (#10110) 2023-05-03 18:26:51 -07:00
Jay Zhuang
3a37ed268f
Merge pull request #10053 from sfc-gh-satherton/random-kv-generator
Runtime configurable random KV generator classes
2023-05-03 17:57:49 -07:00
Jay Zhuang
d0cb599c7a Fix a gcc build error
```
RandomKeyValueUtils.cpp:64:106: error: call of overloaded 'RandomKeyTupleGenerator(<brace-enclosed initializer list>)' is ambiguous
```
2023-05-03 16:33:04 -07:00
A.J. Beamon
95cf9948a1 Add API version protection for the change to use a default option for used during commit protection in Java 2023-05-03 16:18:11 -07:00
Jay Zhuang
a18bb10bcf Merge branch 'main' into random-kv-generator 2023-05-03 15:39:37 -07:00
Zhe Wang
d254fba6e5
Adding cleanup of audit progress metadata when audit complete (#10118)
* cleanup audit progress metadata and tester directly issue audit requests to DD instead of CC

* address comments and fix test dd issue request but dd not present
2023-05-03 15:39:22 -07:00
A.J. Beamon
ccf61ac2e5 Do not allow changing the coordinators to a set that is unreliable, because otherwise we could delete our coordinated state 2023-05-03 15:03:03 -07:00
Jingyu Zhou
dd25fae3d9
Add 7.1.32, 7.1.33 release notes (#10122) 2023-05-03 14:56:43 -07:00
zhongxing.zhang
b31dce9f33 add comments to explain difference between completeSources and src 2023-05-03 14:48:22 -07:00
Xiaoxi Wang
91de1c880e remove PrepareBlobRestore waiting for inFlight moving 2023-05-03 14:43:23 -07:00
Xiaoxi Wang
d7c089fd13 add timeout to blob migrator getReply to tackle recovery during preparation 2023-05-03 14:43:23 -07:00
Jingyu Zhou
64a6ab7122 Add ID to DEBUG_MUTATION in backup worker 2023-05-03 13:15:18 -07:00
Jingyu Zhou
9219ff51db Avoid double escaping for SSValidateRangeKeyOutOfRange events 2023-05-03 13:15:18 -07:00
Steve Atherton
a263be37a6
Merge pull request #10109 from sfc-gh-satherton/btree-shutdown-fixes
AsyncFileWriteChecker false-positive bug fix and sim-only Redwood shutdown improvements found along the way.
2023-05-03 11:34:04 -07:00
Steve Atherton
95be00a8be Move AsyncFileWriteChecker to right above SimpleFile in the file stack in simulation, which is analogous to where it is created in production and prevents false positive errors caused by stacking it on top of AsyncFileNonDurable multiple times for different users of the same file. 2023-05-03 10:39:13 -07:00
Josh Slocum
22155c84f4
adding logic to disable splitting within a truncated tuple, and validating it in test (#10106) 2023-05-03 10:23:46 -05:00
Steve Atherton
f3a5f434ee Fix for false positive AsyncFileWriteChecker errors. AsyncFileWriteChecker should not validate read checksums after the user has dropped all references to the file as the file could have been opened and written to via another file handle before the read completes. 2023-05-03 00:26:58 -07:00
Steve Atherton
e72ea6b603 Restore original functionality of debug_printf_always. 2023-05-03 00:24:54 -07:00
Steve Atherton
18468b417c Fix divide by zero. 2023-05-03 00:20:46 -07:00
Ata E Husain Bohra
7e872c4a59
EaR: Avoid RESTKmsConnector code to use 'Type' in TraceEvents (#10108)
Description

'Type' is a reserved keywork for TraceEvent, RESTKmsConnector
was usng 'Type' to log CipherDetail or BlobMetadata type information.
It causes 'fdbserver' binary to crash/restart

Patch addresses the usage to ensure TraceEvent compatibility is
maintained. Further, it proposes following test improvements:
1. Fix existing unit-test that 'should' have caught this issue.
2. Add more test coverage.
3. Add CODE_PROBE to ensure relevant corner cases are validated.

Testing

RESTKmsConnectorUnit
2023-05-02 20:56:57 -07:00
Steve Atherton
9eaa829626 Make ICloseable()::close() implementations delete the object *before* triggering the onClosed() future. 2023-05-02 19:03:15 -07:00
Steve Atherton
cdd7c410fe Sim-only bug fix which only affects BTree unit test. BTree destruction was not explicitly cancelling the lazy delete actor, so an immediate re-open of the instance could cause two AsyncFileWriteCheckers to exist on the same file at the same time. 2023-05-02 18:59:33 -07:00
Zhe Wu
bc7b1d8d81
Merge pull request #10100 from halfprice/zhewu/update-ss-timeout
Increase MAX_STORAGE_COMMIT_TIME to be inline with LOW_PRIORITY_DURABILITY_LAG
2023-05-02 15:30:32 -07:00
Jon Fu
7c5de05cdb
Separate failed and excluded servers on fdbcli output (#10089)
* separate failed and excluded servers on fdbcli output

* change formatting
2023-05-02 14:22:17 -04:00
Zhe Wu
fffdfa5b3d Increase MAX_STORAGE_COMMIT_TIME to be inline with LOW_PRIORITY_DURABILITY_LAG 2023-05-02 11:12:52 -07:00
Jingyu Zhou
60307a0d5c
Merge pull request #10096 from sfc-gh-ajbeamon/fix-pre-commit-config
Fix bad indentation in the pre-commit config
2023-05-02 11:12:30 -07:00
Xiaoxi Wang
ea9a31b4d7 sameId(requesterId)->!sameId(requesterId) 2023-05-02 09:40:11 -07:00
Xiaoxi Wang
f6da0480fc add comments to DDEnabledState and rename some methods 2023-05-02 09:40:11 -07:00
Xiaoxi Wang
a958436bf5 force blob migrator's ssi to be undesired; remove TCServerInfo from prepareBlobMigrator parameter list 2023-05-02 09:40:11 -07:00