apple/foundationdb
1
0
Fork 0
mirror of https://github.com/apple/foundationdb.git synced 2025-05-15 10:22:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix MD formatting in PR template

Browse Source
This commit is contained in:
Markus Pilman 2020-11-13 11:08:35 -07:00
parent abbe370a0b
commit 1142c0675f
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
pull_request_template.md
View File

@ -15,17 +15,17 @@ Changes in this PR:
Please verify that all things listed below were considered and check them. If an item doesn't apply to this type of PR (for example a documentation change doesn't need to be performance tested), you should make a ~~strikethrough~~ (markdown syntax: `~~strikethrough~~`). More infos on the guidlines can be found [here](https://github.com/apple/foundationdb/wiki/FoundationDB-Commit-Process). Please verify that all things listed below were considered and check them. If an item doesn't apply to this type of PR (for example a documentation change doesn't need to be performance tested), you should make a ~~strikethrough~~ (markdown syntax: `~~strikethrough~~`). More infos on the guidlines can be found [here](https://github.com/apple/foundationdb/wiki/FoundationDB-Commit-Process).
### Style ### Style
[] All variable and function names make sense. - [ ] All variable and function names make sense.
[] The code is properly formatted (consider running `git clang-format`). - [ ] The code is properly formatted (consider running `git clang-format`).
### Performance ### Performance
[] All CPU-hot paths are well optimized. - [ ] All CPU-hot paths are well optimized.
[] The proper containers are used (for example `std::vector` vs `VectorRef`). - [ ] The proper containers are used (for example `std::vector` vs `VectorRef`).
[] There are no new known `SlowTask` traces. - [ ] There are no new known `SlowTask` traces.
### Testing ### Testing
[] The code was sufficiently tested in simulation. - [ ] The code was sufficiently tested in simulation.
[] If there are new parameters or knobs, different values are tested in simulation. - [ ] If there are new parameters or knobs, different values are tested in simulation.
[] `ASSERT`, `ASSERT_WE_THINK`, and `TEST` macros are added in appropriate places. - [ ] `ASSERT`, `ASSERT_WE_THINK`, and `TEST` macros are added in appropriate places.
[] Unit tests were added for new algorithms and data structure that make sense to unit-test - [ ] Unit tests were added for new algorithms and data structure that make sense to unit-test
[] If this is a bugfix: there is a test that can easily reproduce the bug. - [ ] If this is a bugfix: there is a test that can easily reproduce the bug.