From 1142c0675fbd42420e37f3d084f8b22fde4bf7ad Mon Sep 17 00:00:00 2001 From: Markus Pilman <markus.pilman@snowflake.com> Date: Fri, 13 Nov 2020 11:08:35 -0700 Subject: [PATCH] fix MD formatting in PR template --- pull_request_template.md | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index c0a98e1cd0..15a59664d1 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -15,17 +15,17 @@ Changes in this PR: Please verify that all things listed below were considered and check them. If an item doesn't apply to this type of PR (for example a documentation change doesn't need to be performance tested), you should make a ~~strikethrough~~ (markdown syntax: `~~strikethrough~~`). More infos on the guidlines can be found [here](https://github.com/apple/foundationdb/wiki/FoundationDB-Commit-Process). ### Style -[] All variable and function names make sense. -[] The code is properly formatted (consider running `git clang-format`). +- [ ] All variable and function names make sense. +- [ ] The code is properly formatted (consider running `git clang-format`). ### Performance -[] All CPU-hot paths are well optimized. -[] The proper containers are used (for example `std::vector` vs `VectorRef`). -[] There are no new known `SlowTask` traces. +- [ ] All CPU-hot paths are well optimized. +- [ ] The proper containers are used (for example `std::vector` vs `VectorRef`). +- [ ] There are no new known `SlowTask` traces. ### Testing -[] The code was sufficiently tested in simulation. -[] If there are new parameters or knobs, different values are tested in simulation. -[] `ASSERT`, `ASSERT_WE_THINK`, and `TEST` macros are added in appropriate places. -[] Unit tests were added for new algorithms and data structure that make sense to unit-test -[] If this is a bugfix: there is a test that can easily reproduce the bug. +- [ ] The code was sufficiently tested in simulation. +- [ ] If there are new parameters or knobs, different values are tested in simulation. +- [ ] `ASSERT`, `ASSERT_WE_THINK`, and `TEST` macros are added in appropriate places. +- [ ] Unit tests were added for new algorithms and data structure that make sense to unit-test +- [ ] If this is a bugfix: there is a test that can easily reproduce the bug.