15 Commits

Author SHA1 Message Date
Charles Lyding
c1512e4274 build: update files to be eslint compliant
All TypeScript files have been updated to pass the new eslint-based linting checks. eslint compatible disabling comments have also been added in place of the previous tslint comments.
2021-05-03 07:31:02 -04:00
Charles Lyding
37a06a7c37 build: format all files
All files are now formatted using the ng-dev tools via prettier.
2021-04-28 16:05:49 -07:00
Joey Perrott
003854257c build: migrate all file header to use Google LLC rather than Google Inc 2021-04-27 08:35:22 +02:00
Keen Yee Liau
3227e89588 ci: remove unused --ci option from validate script 2021-04-13 11:50:43 -04:00
Alan Agius
ab84fc56b3 ci: remove validate-do-not-submit check
This uses  `git merge-base --fork-point master` which currently is not yielding a SHA on the patch branch. In some cases merge-base will not working as expected when base is ahead. See https://public-inbox.org/git/xmqq375okvxy.fsf@gitster.mtv.corp.google.com/T/#r3830f032d76f39b82d0ffe7f8bd77351cf634d29

This validation checks if `DO_NOT_SUBMIT` string literal has been added using `git diff`, when present validation will fail.

This check is unneeded as we do not use the `DO_NOT_SUBMIT` pattern, as we typically use `wip!` commit message types.
2021-02-03 12:18:26 -05:00
Charles Lyding
df49fd6ad8 build: remove existing commit message validation
The shared dev-infra toolset is now used to perform commit message validation.
2020-10-05 14:11:17 -04:00
Charles Lyding
c75ae25025 ci: use CircleCI pipeline SHA variables for commit validation 2020-07-23 22:41:00 +02:00
Alan Agius
a6fbee6865 style: add no-invalid-await and prefer-promise-shorthand lint rules (#15450)
Add these two lint rules for a better code quality and readability
2019-08-27 10:24:58 -07:00
Hans Larsen
2ffbdfa86a build: add a validation script for the analytics.md tables
Also added enums to update when changing dimensions.
2019-03-28 13:28:41 -07:00
Hans Larsen
7eb4bab00f build: add validation for "DO NOT SUBMIT" strings
This makes sure that messages that should not be submitted (or
comments) fail validation on CI.
2019-03-11 13:38:00 -07:00
Hans
202117a68e ci: add CONTRIBUTING as a template and various changes
Added types from the commit validation script to CONTRIBUTING. Added
packages names from the package script to the scope section. Added
examples of good commit messages.

Also corrected some texts.
2018-10-03 16:33:07 -07:00
Hans
d7e7cd2282 ci: fix validate script to properly report errors 2018-07-23 11:06:01 -07:00
Hans Larsen
483cbe2665 refactor: add tslint-sonarts and a lot of tslint rules
This should clean up the code a bit.

Note: at first I added the no-useless-cast rule, but after getting frustrated
with it (as it has many false positive), I decided to remove the rule but some
useless casts were removed so I let those in the PR.
2018-07-10 15:07:36 -07:00
Hans
47892d2e1b ci: validate is really async and validate-commits should return errorcode
Instead of process.exit() which is a bit premature
2018-06-09 10:01:10 +01:00
Hans Larsen
44086c60ff build: move devkit repo back to angular-cli 2018-06-05 18:50:06 -07:00