Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-15 01:54:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

ci: fix validate script to properly report errors

Browse Source
This commit is contained in:
Hans 2018-07-16 10:48:57 -07:00
parent e17a2edcc7
commit d7e7cd2282
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
scripts/validate-build-files.ts
View File

@ -11,7 +11,7 @@ import { existsSync } from 'fs';
import { join } from 'path';
import { packages } from '../lib/packages';
export default function (_options: {}, logger: logging.Logger) {
export default async function (_options: {}, logger: logging.Logger) {
let error = false;
for (const pkgName of Object.keys(packages)) {
@ -37,4 +37,6 @@ export default function (_options: {}, logger: logging.Logger) {
// process.exit(1);
logger.warn('Found some BUILD files missing, which will be breaking your PR soon.');
}
return 0;
}

7
scripts/validate.ts
View File

@ -39,8 +39,8 @@ export default async function (options: { verbose: boolean }, logger: logging.Lo
logger.info('');
logger.info('Running commit validation...');
validateCommits({}, logger.createChild('validate-commits'));
error = await validateCommits({}, logger.createChild('validate-commits')) != 0
|| error;
logger.info('');
logger.info('Running license validation...');
@ -49,7 +49,8 @@ export default async function (options: { verbose: boolean }, logger: logging.Lo
logger.info('');
logger.info('Running BUILD files validation...');
validateBuildFiles({}, logger.createChild('validate-build-files'));
error = await validateBuildFiles({}, logger.createChild('validate-build-files')) != 0
|| error;
if (error) {
return 101;