Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-16 18:43:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(@angular-devkit/core): update logger forEach promiseCtor type

Browse Source 
`typeof Promise` and `PromiseConstructorLike` are not the same thing. This causes issues in G3 when `strictNullChecks` are being enabled using RXJS 7.
This commit is contained in:
Alan Agius 2022-10-14 06:53:29 +00:00 committed by Alan Agius
parent 1cd53d6be1
commit cf1b7789a5
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
goldens/public-api/angular_devkit/core/index.md
View File

@ -459,7 +459,7 @@ class Logger extends Observable<LogEntry> implements LoggerApi {
// (undocumented)
fatal(message: string, metadata?: JsonObject): void;
// (undocumented)
forEach(next: (value: LogEntry) => void, promiseCtor?: typeof Promise): Promise<void>;
forEach(next: (value: LogEntry) => void, promiseCtor?: PromiseConstructorLike): Promise<void>;
// (undocumented)
info(message: string, metadata?: JsonObject): void;
// (undocumented)

5
packages/angular_devkit/core/src/logger/logger.ts
View File

@ -162,7 +162,10 @@ export class Logger extends Observable<LogEntry> implements LoggerApi {
);
}
override forEach(next: (value: LogEntry) => void, promiseCtor?: typeof Promise): Promise<void> {
override forEach(
next: (value: LogEntry) => void,
promiseCtor?: PromiseConstructorLike,
): Promise<void> {
return this._observable.forEach(next, promiseCtor);
}
}