From cf1b7789a5055f0fe3a17ae34de48ac3d9869b06 Mon Sep 17 00:00:00 2001
From: Alan Agius <alanagius@google.com>
Date: Fri, 14 Oct 2022 06:53:29 +0000
Subject: [PATCH] fix(@angular-devkit/core): update logger `forEach`
 `promiseCtor` type

`typeof Promise` and `PromiseConstructorLike` are not the same thing. This causes issues in G3 when `strictNullChecks` are being enabled using RXJS 7.
---
 goldens/public-api/angular_devkit/core/index.md   | 2 +-
 packages/angular_devkit/core/src/logger/logger.ts | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/goldens/public-api/angular_devkit/core/index.md b/goldens/public-api/angular_devkit/core/index.md
index 23cda881f1..626dc8eaf7 100644
--- a/goldens/public-api/angular_devkit/core/index.md
+++ b/goldens/public-api/angular_devkit/core/index.md
@@ -459,7 +459,7 @@ class Logger extends Observable<LogEntry> implements LoggerApi {
     // (undocumented)
     fatal(message: string, metadata?: JsonObject): void;
     // (undocumented)
-    forEach(next: (value: LogEntry) => void, promiseCtor?: typeof Promise): Promise<void>;
+    forEach(next: (value: LogEntry) => void, promiseCtor?: PromiseConstructorLike): Promise<void>;
     // (undocumented)
     info(message: string, metadata?: JsonObject): void;
     // (undocumented)
diff --git a/packages/angular_devkit/core/src/logger/logger.ts b/packages/angular_devkit/core/src/logger/logger.ts
index 195cf23aeb..77ef48ef17 100644
--- a/packages/angular_devkit/core/src/logger/logger.ts
+++ b/packages/angular_devkit/core/src/logger/logger.ts
@@ -162,7 +162,10 @@ export class Logger extends Observable<LogEntry> implements LoggerApi {
     );
   }
 
-  override forEach(next: (value: LogEntry) => void, promiseCtor?: typeof Promise): Promise<void> {
+  override forEach(
+    next: (value: LogEntry) => void,
+    promiseCtor?: PromiseConstructorLike,
+  ): Promise<void> {
     return this._observable.forEach(next, promiseCtor);
   }
 }