Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-16 10:33:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "feat(@angular/cli): Add VsCode recommendation for Angular Console"

Browse Source 
This reverts commit 3d6ae631788b600a1b80132ae407f15ad3dc65aa.
This commit is contained in:
Alex Eagle 2019-02-28 10:24:46 -08:00
parent 242ebd932f
commit 71428bd9cb
3 changed files with 9 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0.ts
View File

@ -15,15 +15,12 @@ export default function (): Rule {
const addExtensionRecommendations = updateJsonInTree(
'.vscode/extensions.json',
(json: { recommendations?: string[] }) => {
[
'angular.ng-template',
'nrwl.angular-console',
'ms-vscode.vscode-typescript-tslint-plugin'].forEach(extension => {
json.recommendations = json.recommendations || [];
if (!json.recommendations.includes(extension)) {
json.recommendations.push(extension);
}
});
['angular.ng-template', 'ms-vscode.vscode-typescript-tslint-plugin'].forEach(extension => {
json.recommendations = json.recommendations || [];
if (!json.recommendations.includes(extension)) {
json.recommendations.push(extension);
}
});
return json;
},

13
packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0_spec.ts
View File

@ -35,8 +35,7 @@ describe('Update 8.0.0', () => {
.toPromise();
expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({
recommendations: [
'angular.ng-template', 'nrwl.angular-console', 'ms-vscode.vscode-typescript-tslint-plugin'],
recommendations: ['angular.ng-template', 'ms-vscode.vscode-typescript-tslint-plugin'],
});
});
@ -45,10 +44,7 @@ describe('Update 8.0.0', () => {
.callRule(
updateJsonInTree('.vscode/extensions.json', () => ({
recommendations: [
'eamodio.gitlens',
'angular.ng-template',
'nrwl.angular-console',
'ms-vscode.vscode-typescript-tslint-plugin'],
'eamodio.gitlens', 'angular.ng-template', 'ms-vscode.vscode-typescript-tslint-plugin'],
})),
initialTree,
)
@ -60,10 +56,7 @@ describe('Update 8.0.0', () => {
expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({
recommendations: [
'eamodio.gitlens',
'angular.ng-template',
'nrwl.angular-console',
'ms-vscode.vscode-typescript-tslint-plugin'],
'eamodio.gitlens', 'angular.ng-template', 'ms-vscode.vscode-typescript-tslint-plugin'],
});
});
});

1
packages/schematics/angular/workspace/files/__dot__vscode/extensions.json.template
View File

@ -1,7 +1,6 @@
{
"recommendations": [
"angular.ng-template",
"nrwl.angular-console",
"ms-vscode.vscode-typescript-tslint-plugin"
]
}