From 71428bd9cba1c25c98c55d8d5f3e55951413cdbd Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Thu, 28 Feb 2019 10:24:46 -0800 Subject: [PATCH] Revert "feat(@angular/cli): Add VsCode recommendation for Angular Console" This reverts commit 3d6ae631788b600a1b80132ae407f15ad3dc65aa. --- .../update-vscode-recommendations/update-8.0.0.ts | 15 ++++++--------- .../update-8.0.0_spec.ts | 13 +++---------- .../files/__dot__vscode/extensions.json.template | 1 - 3 files changed, 9 insertions(+), 20 deletions(-) diff --git a/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0.ts b/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0.ts index 9b4bba7225..41101d48de 100644 --- a/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0.ts +++ b/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0.ts @@ -15,15 +15,12 @@ export default function (): Rule { const addExtensionRecommendations = updateJsonInTree( '.vscode/extensions.json', (json: { recommendations?: string[] }) => { - [ - 'angular.ng-template', - 'nrwl.angular-console', - 'ms-vscode.vscode-typescript-tslint-plugin'].forEach(extension => { - json.recommendations = json.recommendations || []; - if (!json.recommendations.includes(extension)) { - json.recommendations.push(extension); - } - }); + ['angular.ng-template', 'ms-vscode.vscode-typescript-tslint-plugin'].forEach(extension => { + json.recommendations = json.recommendations || []; + if (!json.recommendations.includes(extension)) { + json.recommendations.push(extension); + } + }); return json; }, diff --git a/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0_spec.ts b/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0_spec.ts index f45de65b9f..40be71afa9 100644 --- a/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0_spec.ts +++ b/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0_spec.ts @@ -35,8 +35,7 @@ describe('Update 8.0.0', () => { .toPromise(); expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({ - recommendations: [ - 'angular.ng-template', 'nrwl.angular-console', 'ms-vscode.vscode-typescript-tslint-plugin'], + recommendations: ['angular.ng-template', 'ms-vscode.vscode-typescript-tslint-plugin'], }); }); @@ -45,10 +44,7 @@ describe('Update 8.0.0', () => { .callRule( updateJsonInTree('.vscode/extensions.json', () => ({ recommendations: [ - 'eamodio.gitlens', - 'angular.ng-template', - 'nrwl.angular-console', - 'ms-vscode.vscode-typescript-tslint-plugin'], + 'eamodio.gitlens', 'angular.ng-template', 'ms-vscode.vscode-typescript-tslint-plugin'], })), initialTree, ) @@ -60,10 +56,7 @@ describe('Update 8.0.0', () => { expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({ recommendations: [ - 'eamodio.gitlens', - 'angular.ng-template', - 'nrwl.angular-console', - 'ms-vscode.vscode-typescript-tslint-plugin'], + 'eamodio.gitlens', 'angular.ng-template', 'ms-vscode.vscode-typescript-tslint-plugin'], }); }); }); diff --git a/packages/schematics/angular/workspace/files/__dot__vscode/extensions.json.template b/packages/schematics/angular/workspace/files/__dot__vscode/extensions.json.template index 668282bf7a..a69da09b88 100644 --- a/packages/schematics/angular/workspace/files/__dot__vscode/extensions.json.template +++ b/packages/schematics/angular/workspace/files/__dot__vscode/extensions.json.template @@ -1,7 +1,6 @@ { "recommendations": [ "angular.ng-template", - "nrwl.angular-console", "ms-vscode.vscode-typescript-tslint-plugin" ] }