Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-25 00:31:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #14287 from kara/revert-pure-getters

Browse Source 
Revert "fix(@angular-devkit/build-angular): remove pure_getters"
This commit is contained in:
Kara 2019-04-26 12:13:59 -07:00 committed by Alex Eagle
parent f189596414
commit 29609fb078
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts
View File

@ -279,13 +279,18 @@ export function getCommonConfig(wco: WebpackConfigOptions): Configuration {
comments: false, comments: false,
webkit: true, webkit: true,
}, },
compress: { // On server, we don't want to compress anything. We still set the ngDevMode = false for it
// PURE comments work best with 3 passes. // to remove dev code, and ngI18nClosureMode to remove Closure compiler i18n code
// See https://github.com/webpack/webpack/issues/2899#issuecomment-317425926. compress: (buildOptions.platform == 'server' ? {
passes: 3,
global_defs: angularGlobalDefinitions, global_defs: angularGlobalDefinitions,
}, } : {
// We want to avoid mangling on server. pure_getters: buildOptions.buildOptimizer,
// PURE comments work best with 3 passes.
// See https://github.com/webpack/webpack/issues/2899#issuecomment-317425926.
passes: buildOptions.buildOptimizer ? 3 : 1,
global_defs: angularGlobalDefinitions,
}),
// We also want to avoid mangling on server.
...(buildOptions.platform == 'server' ? { mangle: false } : {}), ...(buildOptions.platform == 'server' ? { mangle: false } : {}),
}; };