From 29609fb0785646fdbb636b08853a13df65fac06a Mon Sep 17 00:00:00 2001 From: Kara Date: Fri, 26 Apr 2019 12:13:59 -0700 Subject: [PATCH] Merge pull request #14287 from kara/revert-pure-getters Revert "fix(@angular-devkit/build-angular): remove pure_getters" --- .../models/webpack-configs/common.ts | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts b/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts index 4df73e82b8..7d76a8f926 100644 --- a/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts +++ b/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts @@ -279,13 +279,18 @@ export function getCommonConfig(wco: WebpackConfigOptions): Configuration { comments: false, webkit: true, }, - compress: { - // PURE comments work best with 3 passes. - // See https://github.com/webpack/webpack/issues/2899#issuecomment-317425926. - passes: 3, + // On server, we don't want to compress anything. We still set the ngDevMode = false for it + // to remove dev code, and ngI18nClosureMode to remove Closure compiler i18n code + compress: (buildOptions.platform == 'server' ? { global_defs: angularGlobalDefinitions, - }, - // We want to avoid mangling on server. + } : { + pure_getters: buildOptions.buildOptimizer, + // PURE comments work best with 3 passes. + // See https://github.com/webpack/webpack/issues/2899#issuecomment-317425926. + passes: buildOptions.buildOptimizer ? 3 : 1, + global_defs: angularGlobalDefinitions, + }), + // We also want to avoid mangling on server. ...(buildOptions.platform == 'server' ? { mangle: false } : {}), };