Graham/angular-cli
1
0
Fork 0
mirror of https://github.com/angular/angular-cli.git synced 2025-05-22 15:02:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "feat(@schematics/angular): recommend plugins that John Papa recommends"

Browse Source 
This reverts commit 3a68b8cf9696e678308da65ca59b53329981c94f.
This commit is contained in:
Alex Eagle 2019-02-28 10:24:44 -08:00
parent ef11c9fbc9
commit 242ebd932f
3 changed files with 12 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0.ts
View File

@ -18,13 +18,7 @@ const addExtensionRecommendations = updateJsonInTree(
[ [
'angular.ng-template', 'angular.ng-template',
'nrwl.angular-console', 'nrwl.angular-console',
'ms-vscode.vscode-typescript-tslint-plugin', 'ms-vscode.vscode-typescript-tslint-plugin'].forEach(extension => {
'Mikael.Angular-BeastCode',
'EditorConfig.EditorConfig',
'msjsdiag.debugger-for-chrome',
'eg2.vscode-npm-script',
'PKief.material-icon-theme',
'natewallace.angular2-inline'].forEach(extension => {
json.recommendations = json.recommendations || []; json.recommendations = json.recommendations || [];
if (!json.recommendations.includes(extension)) { if (!json.recommendations.includes(extension)) {
json.recommendations.push(extension); json.recommendations.push(extension);

25
packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0_spec.ts
View File

@ -9,18 +9,6 @@ import { Tree } from '@angular-devkit/schematics';
import { SchematicTestRunner } from '@angular-devkit/schematics/testing'; import { SchematicTestRunner } from '@angular-devkit/schematics/testing';
import { readJsonInTree, serializeJson, updateJsonInTree } from './ast-utils'; import { readJsonInTree, serializeJson, updateJsonInTree } from './ast-utils';
const recommendations = [
'angular.ng-template',
'nrwl.angular-console',
'ms-vscode.vscode-typescript-tslint-plugin',
'Mikael.Angular-BeastCode',
'EditorConfig.EditorConfig',
'msjsdiag.debugger-for-chrome',
'eg2.vscode-npm-script',
'PKief.material-icon-theme',
'natewallace.angular2-inline',
];
describe('Update 8.0.0', () => { describe('Update 8.0.0', () => {
let initialTree: Tree; let initialTree: Tree;
let schematicRunner: SchematicTestRunner; let schematicRunner: SchematicTestRunner;
@ -46,7 +34,10 @@ describe('Update 8.0.0', () => {
.runSchematicAsync('migration-07', {}, initialTree) .runSchematicAsync('migration-07', {}, initialTree)
.toPromise(); .toPromise();
expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({recommendations}); expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({
recommendations: [
'angular.ng-template', 'nrwl.angular-console', 'ms-vscode.vscode-typescript-tslint-plugin'],
});
}); });
it('should add to existing vscode extension recommendations', async () => { it('should add to existing vscode extension recommendations', async () => {
@ -55,7 +46,9 @@ describe('Update 8.0.0', () => {
updateJsonInTree('.vscode/extensions.json', () => ({ updateJsonInTree('.vscode/extensions.json', () => ({
recommendations: [ recommendations: [
'eamodio.gitlens', 'eamodio.gitlens',
...recommendations], 'angular.ng-template',
'nrwl.angular-console',
'ms-vscode.vscode-typescript-tslint-plugin'],
})), })),
initialTree, initialTree,
) )
@ -68,7 +61,9 @@ describe('Update 8.0.0', () => {
expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({ expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({
recommendations: [ recommendations: [
'eamodio.gitlens', 'eamodio.gitlens',
...recommendations], 'angular.ng-template',
'nrwl.angular-console',
'ms-vscode.vscode-typescript-tslint-plugin'],
}); });
}); });
}); });

8
packages/schematics/angular/workspace/files/__dot__vscode/extensions.json.template
View File

@ -2,12 +2,6 @@
"recommendations": [ "recommendations": [
"angular.ng-template", "angular.ng-template",
"nrwl.angular-console", "nrwl.angular-console",
"ms-vscode.vscode-typescript-tslint-plugin", "ms-vscode.vscode-typescript-tslint-plugin"
"Mikael.Angular-BeastCode",
"EditorConfig.EditorConfig",
"msjsdiag.debugger-for-chrome",
"eg2.vscode-npm-script",
"PKief.material-icon-theme",
"natewallace.angular2-inline"
] ]
} }