diff --git a/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0.ts b/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0.ts index 76ae078385..9b4bba7225 100644 --- a/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0.ts +++ b/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0.ts @@ -18,13 +18,7 @@ const addExtensionRecommendations = updateJsonInTree( [ 'angular.ng-template', 'nrwl.angular-console', - 'ms-vscode.vscode-typescript-tslint-plugin', - 'Mikael.Angular-BeastCode', - 'EditorConfig.EditorConfig', - 'msjsdiag.debugger-for-chrome', - 'eg2.vscode-npm-script', - 'PKief.material-icon-theme', - 'natewallace.angular2-inline'].forEach(extension => { + 'ms-vscode.vscode-typescript-tslint-plugin'].forEach(extension => { json.recommendations = json.recommendations || []; if (!json.recommendations.includes(extension)) { json.recommendations.push(extension); diff --git a/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0_spec.ts b/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0_spec.ts index d5b7ed948f..f45de65b9f 100644 --- a/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0_spec.ts +++ b/packages/schematics/angular/migrations/update-vscode-recommendations/update-8.0.0_spec.ts @@ -9,18 +9,6 @@ import { Tree } from '@angular-devkit/schematics'; import { SchematicTestRunner } from '@angular-devkit/schematics/testing'; import { readJsonInTree, serializeJson, updateJsonInTree } from './ast-utils'; -const recommendations = [ - 'angular.ng-template', - 'nrwl.angular-console', - 'ms-vscode.vscode-typescript-tslint-plugin', - 'Mikael.Angular-BeastCode', - 'EditorConfig.EditorConfig', - 'msjsdiag.debugger-for-chrome', - 'eg2.vscode-npm-script', - 'PKief.material-icon-theme', - 'natewallace.angular2-inline', -]; - describe('Update 8.0.0', () => { let initialTree: Tree; let schematicRunner: SchematicTestRunner; @@ -46,7 +34,10 @@ describe('Update 8.0.0', () => { .runSchematicAsync('migration-07', {}, initialTree) .toPromise(); - expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({recommendations}); + expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({ + recommendations: [ + 'angular.ng-template', 'nrwl.angular-console', 'ms-vscode.vscode-typescript-tslint-plugin'], + }); }); it('should add to existing vscode extension recommendations', async () => { @@ -55,7 +46,9 @@ describe('Update 8.0.0', () => { updateJsonInTree('.vscode/extensions.json', () => ({ recommendations: [ 'eamodio.gitlens', - ...recommendations], + 'angular.ng-template', + 'nrwl.angular-console', + 'ms-vscode.vscode-typescript-tslint-plugin'], })), initialTree, ) @@ -68,7 +61,9 @@ describe('Update 8.0.0', () => { expect(readJsonInTree(result, '.vscode/extensions.json')).toEqual({ recommendations: [ 'eamodio.gitlens', - ...recommendations], + 'angular.ng-template', + 'nrwl.angular-console', + 'ms-vscode.vscode-typescript-tslint-plugin'], }); }); }); diff --git a/packages/schematics/angular/workspace/files/__dot__vscode/extensions.json.template b/packages/schematics/angular/workspace/files/__dot__vscode/extensions.json.template index 9b4375bca6..668282bf7a 100644 --- a/packages/schematics/angular/workspace/files/__dot__vscode/extensions.json.template +++ b/packages/schematics/angular/workspace/files/__dot__vscode/extensions.json.template @@ -2,12 +2,6 @@ "recommendations": [ "angular.ng-template", "nrwl.angular-console", - "ms-vscode.vscode-typescript-tslint-plugin", - "Mikael.Angular-BeastCode", - "EditorConfig.EditorConfig", - "msjsdiag.debugger-for-chrome", - "eg2.vscode-npm-script", - "PKief.material-icon-theme", - "natewallace.angular2-inline" + "ms-vscode.vscode-typescript-tslint-plugin" ] }