postgres/typesense
1
0
Fork 0
mirror of https://github.com/typesense/typesense.git synced 2025-05-20 05:32:30 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Wrap embedded param filter with () for better exclusivity.

Browse Source
This commit is contained in:
Kishore Nallan 2022-10-30 15:37:51 +05:30
parent eeda046561
commit fe4a81d2da
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/auth_manager.cpp
View File

@ -391,7 +391,7 @@ bool AuthManager::add_item_to_params(std::map<std::string, std::string>& req_par
if(req_params.count(item.key()) == 0) {
req_params[item.key()] = str_value;
} else if(item.key() == "filter_by") {
req_params[item.key()] = req_params[item.key()] + "&&" + str_value;
req_params[item.key()] = "(" + req_params[item.key()] + ") && (" + str_value + ")";
} else if(overwrite) {
req_params[item.key()] = str_value;
}

2
test/collection_manager_test.cpp
View File

@ -547,7 +547,7 @@ TEST_F(CollectionManagerTest, VerifyEmbeddedParametersOfScopedAPIKey) {
ASSERT_EQ(1, res_obj["found"].get<size_t>());
ASSERT_EQ(1, res_obj["hits"].size());
ASSERT_STREQ("1", results["hits"][0]["document"]["id"].get<std::string>().c_str());
ASSERT_EQ("year: 1922&&points: 200", req_params["filter_by"]);
ASSERT_EQ("(year: 1922) && (points: 200)", req_params["filter_by"]);
collectionManager.drop_collection("coll1");
}

2
test/core_api_utils_test.cpp
View File

@ -197,7 +197,7 @@ TEST_F(CoreAPIUtilsTest, MultiSearchEmbeddedKeys) {
post_multi_search(req, res);
// ensure that req params are appended to (embedded params are also rolled into req params)
ASSERT_EQ("user_id: 100&&age: > 100&&foo: bar", req->params["filter_by"]);
ASSERT_EQ("((user_id: 100) && (age: > 100)) && (foo: bar)", req->params["filter_by"]);
// try setting max search limit
req->embedded_params_vec[0]["limit_multi_searches"] = 0;