postgres/typesense
1
0
Fork 0
mirror of https://github.com/typesense/typesense.git synced 2025-05-18 20:52:50 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Allow spaces in range facet string.

Browse Source
This commit is contained in:
Kishore Nallan 2023-05-03 15:14:12 +05:30
parent 7515e733db
commit f0b90c114f
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/collection.cpp
View File

@ -4535,7 +4535,7 @@ bool Collection::get_enable_nested_fields() {
Option<bool> Collection::parse_facet(const std::string& facet_field, std::vector<facet>& facets) const{
const std::regex base_pattern(".+\\(.*\\)");
const std::regex range_pattern("[[a-zA-Z]+:\\[([0-9]+)\\, ([0-9]+)\\]");
const std::regex range_pattern("[[a-zA-Z]+:\\[([0-9]+)\\,\\s*([0-9]+)\\]");
if(facet_field.find(":") != std::string::npos) { //range based facet
if(!std::regex_match(facet_field, base_pattern)){

3
test/collection_faceting_test.cpp
View File

@ -1130,9 +1130,10 @@ TEST_F(CollectionFacetingTest, FacetParseTest){
ASSERT_TRUE(expected.count(wildcard_facets[i].field_name) == 1);
}
// should also allow zero or more spaces after ","
std::vector<std::string> mixed_facet_fields {
"score",
"grade(A:[80, 100], B:[60, 80], C:[40, 60])",
"grade(A:[80, 100], B:[60, 80], C:[40,60])",
"ra*",
};