From eb298ff9a086edb4030c5dbae6ed735aba40423b Mon Sep 17 00:00:00 2001 From: Harpreet Sangar Date: Fri, 5 May 2023 12:34:17 +0530 Subject: [PATCH] Fix ASAN issues. --- src/collection.cpp | 2 +- test/filter_test.cpp | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/collection.cpp b/src/collection.cpp index 5eab45f0..976ee70e 100644 --- a/src/collection.cpp +++ b/src/collection.cpp @@ -417,7 +417,7 @@ Option Collection::update_matching_filter(const std::string& fil } const auto& dirty_values = parse_dirty_values_option(req_dirty_values); - size_t docs_updated_count; + size_t docs_updated_count = 0; nlohmann::json update_document, dummy; try { diff --git a/test/filter_test.cpp b/test/filter_test.cpp index ac6efdb4..afce0209 100644 --- a/test/filter_test.cpp +++ b/test/filter_test.cpp @@ -423,7 +423,7 @@ TEST_F(FilterTest, FilterTreeIterator) { } ASSERT_FALSE(iter_to_array_test.is_valid); - delete filter_ids; + delete[] filter_ids; auto iter_and_scalar_test = filter_result_iterator_t(coll->get_name(), coll->_get_index(), filter_tree_root); ASSERT_TRUE(iter_and_scalar_test.init_status().ok()); @@ -440,7 +440,7 @@ TEST_F(FilterTest, FilterTreeIterator) { } ASSERT_FALSE(iter_and_scalar_test.is_valid); - delete and_result; + delete[] and_result; delete filter_tree_root; doc = R"({ @@ -491,6 +491,7 @@ TEST_F(FilterTest, FilterTreeIterator) { phrase_ids[i] = i * 2; } filter_result_iterator_t::add_phrase_ids(iter_add_phrase_ids_test, phrase_ids, 4); + filter_iter_guard.release(); filter_iter_guard.reset(iter_add_phrase_ids_test); ASSERT_TRUE(iter_add_phrase_ids_test->is_valid);