From d6cab80ddeb08a7fc00ff859482dda0f99381e36 Mon Sep 17 00:00:00 2001 From: Kishore Nallan Date: Sat, 26 Mar 2022 16:02:23 +0530 Subject: [PATCH] Return filter_curated_hits in override response. --- include/index.h | 1 + test/collection_override_test.cpp | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/include/index.h b/include/index.h index 9f29a6cd..a9284c90 100644 --- a/include/index.h +++ b/include/index.h @@ -271,6 +271,7 @@ struct override_t { } override["remove_matched_tokens"] = remove_matched_tokens; + override["filter_curated_hits"] = filter_curated_hits; return override; } diff --git a/test/collection_override_test.cpp b/test/collection_override_test.cpp index aafd889d..ffd92ec5 100644 --- a/test/collection_override_test.cpp +++ b/test/collection_override_test.cpp @@ -325,6 +325,12 @@ TEST_F(CollectionOverrideTest, IncludeHitsFilterOverrides) { override_t::parse(override_json_include, "", override_include); coll_mul_fields->add_override(override_include); + std::map overrides = coll_mul_fields->get_overrides(); + ASSERT_EQ(1, overrides.size()); + auto override_json = overrides["include-rule"].to_json(); + ASSERT_TRUE(override_json.contains("filter_curated_hits")); + ASSERT_TRUE(override_json["filter_curated_hits"].get()); + auto results = coll_mul_fields->search("not-found", {"title"}, "points:>70", {"starring"}, {}, {0}, 10, 1, FREQUENCY, {false}, Index::DROP_TOKENS_THRESHOLD, spp::sparse_hash_set(), @@ -432,7 +438,9 @@ TEST_F(CollectionOverrideTest, ExcludeIncludeFacetFilterQuery) { auto override_json = overrides["include-rule"].to_json(); ASSERT_FALSE(override_json.contains("filter_by")); ASSERT_TRUE(override_json.contains("remove_matched_tokens")); + ASSERT_TRUE(override_json.contains("filter_curated_hits")); ASSERT_FALSE(override_json["remove_matched_tokens"].get()); + ASSERT_FALSE(override_json["filter_curated_hits"].get()); auto results = coll_mul_fields->search("not-found", {"title"}, "", {"starring"}, {}, {0}, 10, 1, FREQUENCY, {false}, Index::DROP_TOKENS_THRESHOLD,