postgres/typesense
1
0
Fork 0
mirror of https://github.com/typesense/typesense.git synced 2025-05-18 20:52:50 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Update for process_remove_field_for_embedding_fields

Browse Source
This commit is contained in:
ozanarmagan 2023-04-10 07:32:48 +03:00
parent a50fe99a7c
commit cdbe63747b
2 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/collection.h
View File

@ -162,7 +162,7 @@ private:
void remove_document(const nlohmann::json & document, const uint32_t seq_id, bool remove_from_store);
std::vector<field> process_remove_field_for_embedding_fields(const field& the_field);
void process_remove_field_for_embedding_fields(const field& the_field, std::vector<field>& garbage_fields);
void curate_results(string& actual_query, const string& filter_query, bool enable_overrides, bool already_segmented,
const std::map<size_t, std::vector<std::string>>& pinned_hits,

9
src/collection.cpp
View File

@ -3765,9 +3765,7 @@ Option<bool> Collection::batch_alter_data(const std::vector<field>& alter_fields
default_sorting_field = "";
}
auto garbage_embedding_fields = process_remove_field_for_embedding_fields(del_field);
garbage_embedding_fields_vec.insert(garbage_embedding_fields_vec.end(), garbage_embedding_fields.begin(),
garbage_embedding_fields.end());
process_remove_field_for_embedding_fields(del_field, garbage_embedding_fields_vec);
}
index->refresh_schemas({}, del_fields);
@ -4745,8 +4743,7 @@ Option<bool> Collection::populate_include_exclude_fields_lk(const spp::sparse_ha
}
// Removes the dropped field from embed_from of all embedding fields.
std::vector<field> Collection::process_remove_field_for_embedding_fields(const field& the_field) {
std::vector<field> garbage_fields;
void Collection::process_remove_field_for_embedding_fields(const field& the_field, std::vector<field>& garbage_fields) {
for(auto& field : fields) {
if(field.embed_from.empty()) {
continue;
@ -4763,6 +4760,4 @@ std::vector<field> Collection::process_remove_field_for_embedding_fields(const f
}
}
// return garbage embedding fields
return garbage_fields;
}