postgres/typesense
1
0
Fork 0
mirror of https://github.com/typesense/typesense.git synced 2025-05-22 23:06:30 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fix empty reference array field update. (#1820)

Browse Source
This commit is contained in:
Harpreet Sangar 2024-07-04 12:41:33 +05:30 committed by GitHub
parent 8047b9f359
commit b0014f9c05
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/collection.cpp
View File

@ -349,6 +349,9 @@ Option<bool> Collection::add_reference_helper_fields(nlohmann::json& document, c
filter_query += ",";
}
if (!filter_values_added) {
document[reference_helper_field] = nlohmann::json::array();
document[fields::reference_helper_fields] += reference_helper_field;
continue;
}
filter_query[filter_query.size() - 1] = ']';

2
test/collection_join_test.cpp
View File

@ -1408,7 +1408,7 @@ TEST_F(CollectionJoinTest, JoinAfterUpdateOfArrayField) {
ASSERT_EQ(1, res["hits"][0]["document"]["bodyParts"].size());
ASSERT_EQ(1, res["hits"][0]["document"]["parts"].size());
exercise_doc["bodyParts"] = {};
exercise_doc["bodyParts"] = nlohmann::json::array();
ASSERT_TRUE(exercise_coll->add(exercise_doc.dump(), UPDATE).ok());
req_params = {