postgres/typesense
1
0
Fork 0
mirror of https://github.com/typesense/typesense.git synced 2025-05-25 16:26:38 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add guard for http path being empty.

Browse Source
This commit is contained in:
Kishore Nallan 2021-11-09 07:39:02 +05:30
parent efec5f97e9
commit 9331f996eb
1 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/http_server.cpp
View File

@ -275,9 +275,24 @@ int HttpServer::catch_all_handler(h2o_handler_t *_h2o_handler, h2o_req_t *req) {
const std::string & http_method = std::string(req->method.base, req->method.len);
const std::string & path = std::string(req->path.base, req->path.len);
std::vector<std::string> path_with_query_parts;
StringUtils::split(path, path_with_query_parts, "?");
// These guards have been added to debug a strange issue of `path_with_query_parts` being empty sometimes
if(req->path.len == 0 || path.empty()) {
LOG(ERROR) << "Request path is empty: path.len=" << req->path.len << ", path: " << path;
nlohmann::json resp;
resp["message"] = "Request path is empty.";
return send_response(req, 400, resp.dump());
} else {
StringUtils::split(path, path_with_query_parts, "?");
if(path_with_query_parts.empty()) {
LOG(ERROR) << "Request path is empty after splitting: path=" << path;
nlohmann::json resp;
resp["message"] = "Request path after splitting is empty.";
return send_response(req, 400, resp.dump());
}
}
const std::string & path_without_query = path_with_query_parts[0];
std::string metric_identifier = http_method + " " + path_without_query;