postgres/typesense
1
0
Fork 0
mirror of https://github.com/typesense/typesense.git synced 2025-05-20 21:52:23 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Support resource:* API key permission.

Browse Source
This commit is contained in:
Kishore Nallan 2021-05-10 07:53:53 +05:30
parent ae2055c1ea
commit 7947130a2f
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/auth_manager.cpp
View File

@ -194,6 +194,18 @@ bool AuthManager::auth_against_key(const std::vector<std::string>& collections,
action_is_allowed = true;
break;
}
// e.g. collections:create or documents:create
if (allowed_action.size() >= 2 && allowed_action[allowed_action.size() - 2] == ':' &&
allowed_action.back() == '*') {
std::string allowed_resource = allowed_action.substr(0, allowed_action.size() - 2);
std::vector<std::string> actual_action_parts;
StringUtils::split(action, actual_action_parts, ":");
if(actual_action_parts[0] == allowed_resource) {
action_is_allowed = true;
break;
}
}
}
if(!action_is_allowed) {

8
test/auth_manager_test.cpp
View File

@ -195,6 +195,14 @@ TEST_F(AuthManagerTest, VerifyAuthentication) {
api_key_t unexpired_key1 = api_key_t("abcd9", "expiry key", {"*"}, {"*"}, 2237712220);
auth_manager.create_key(unexpired_key1);
ASSERT_TRUE(auth_manager.authenticate(unexpired_key1.value, "collections:list", {"collection"}, sparams));
// wildcard action on any collection
api_key_t wildcard_action_coll_key = api_key_t("abcd10", "wildcard coll action key", {"collections:*"}, {"*"}, FUTURE_TS);
auth_manager.create_key(wildcard_action_coll_key);
ASSERT_TRUE(auth_manager.authenticate(wildcard_action_coll_key.value, "collections:create", {"collection1"}, sparams));
ASSERT_TRUE(auth_manager.authenticate(wildcard_action_coll_key.value, "collections:delete", {"collection1", "collection2"}, sparams));
ASSERT_FALSE(auth_manager.authenticate(wildcard_action_coll_key.value, "documents:create", {"collection1"}, sparams));
}
TEST_F(AuthManagerTest, HandleAuthentication) {