Use const auto&

This commit is contained in:
ozanarmagan 2023-10-09 13:04:06 +03:00
parent 5e9e08cbc2
commit 73ae433ab5
2 changed files with 2 additions and 3 deletions

View File

@ -3797,8 +3797,8 @@ Option<bool> Collection::batch_alter_data(const std::vector<field>& alter_fields
if(f.embed.count(fields::from) != 0) {
found_embedding_field = true;
auto text_embedders = TextEmbedderManager::get_instance()._get_text_embedders();
auto model_name = f.embed[fields::model_config][fields::model_name].get<std::string>();
const auto& text_embedders = TextEmbedderManager::get_instance()._get_text_embedders();
const auto& model_name = f.embed[fields::model_config][fields::model_name].get<std::string>();
if(text_embedders.count(model_name) == 0) {
size_t dummy_num_dim = 0;
auto validate_model_res = TextEmbedderManager::get_instance().validate_and_init_model(f.embed[fields::model_config], dummy_num_dim);

View File

@ -1567,7 +1567,6 @@ Option<Collection*> CollectionManager::clone_collection(const string& existing_n
void CollectionManager::process_embedding_field_delete(const std::string& model_name) {
// can't have a shared lock here
// because we will be already acquiring a lock on collection manager if we are deleting a collection
//std::shared_lock lock(mutex);
bool found = false;
for(const auto& collection: collections) {