From 6fbc814070db6047ddf8b5c77c768e71c177fa92 Mon Sep 17 00:00:00 2001
From: Kishore Nallan <kishore@kishorelive.com>
Date: Tue, 3 Nov 2020 19:36:07 +0530
Subject: [PATCH] Fix replacing overrides.

---
 src/collection.cpp                | 2 +-
 test/collection_override_test.cpp | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/collection.cpp b/src/collection.cpp
index 78ff3069..62c2c1a7 100644
--- a/src/collection.cpp
+++ b/src/collection.cpp
@@ -1603,7 +1603,7 @@ Option<uint32_t> Collection::add_override(const override_t & override) {
         return Option<uint32_t>(500, "Error while storing the override on disk.");
     }
 
-    overrides.emplace(override.id, override);
+    overrides[override.id] = override;
     return Option<uint32_t>(200);
 }
 
diff --git a/test/collection_override_test.cpp b/test/collection_override_test.cpp
index 312c297c..f5b1c5d6 100644
--- a/test/collection_override_test.cpp
+++ b/test/collection_override_test.cpp
@@ -258,6 +258,11 @@ TEST_F(CollectionOverrideTest, ExcludeIncludeFacetFilterQuery) {
     ASSERT_EQ(1, results["hits"].size());
     ASSERT_EQ("0", results["hits"][0]["document"]["id"].get<std::string>());
 
+    // should be able to replace existing override
+    override_include.rule.query = "found";
+    coll_mul_fields->add_override(override_include);
+    ASSERT_STREQ("found", coll_mul_fields->get_overrides()["include-rule"].rule.query.c_str());
+
     coll_mul_fields->remove_override("include-rule");
 }