postgres/typesense
1
0
Fork 0
mirror of https://github.com/typesense/typesense.git synced 2025-05-20 05:32:30 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Limit per_page to a sane number.

Browse Source
This commit is contained in:
kishorenc 2020-05-31 09:28:50 +05:30
parent a4a51846f7
commit 67185c9ee1
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/collection.h
View File

@ -267,6 +267,8 @@ public:
enum {MAX_ARRAY_MATCHES = 5};
const size_t PER_PAGE_MAX = 250;
// Using a $ prefix so that these meta keys stay above record entries in a lexicographically ordered KV store
static constexpr const char* COLLECTION_META_PREFIX = "$CM";
static constexpr const char* COLLECTION_NEXT_SEQ_PREFIX = "$CS";

8
src/collection.cpp
View File

@ -338,7 +338,7 @@ void Collection::populate_overrides(std::string query,
Option<nlohmann::json> Collection::search(const std::string & query, const std::vector<std::string> & search_fields,
const std::string & simple_filter_query, const std::vector<std::string> & facet_fields,
const std::vector<sort_by> & sort_fields, const int num_typos,
const size_t per_page, const size_t page,
size_t per_page, const size_t page,
const token_ordering token_order, const bool prefix,
const size_t drop_tokens_threshold,
const spp::sparse_hash_set<std::string> & include_fields,
@ -599,7 +599,11 @@ Option<nlohmann::json> Collection::search(const std::string & query, const std::
return Option<nlohmann::json>(422, message);
}
const size_t max_hits = (page * per_page);
// ensure that per_page is limited to PER_PAGE_MAX for sanity
per_page = std::min(per_page, PER_PAGE_MAX);
// ensure that (page * per_page) never exceeds number of documents in collection
const size_t max_hits = std::min((page * per_page), get_num_documents());
std::vector<std::vector<art_leaf*>> searched_queries; // search queries used for generating the results
std::vector<KV> raw_result_kvs;