postgres/typesense
1
0
Fork 0
mirror of https://github.com/typesense/typesense.git synced 2025-05-16 03:12:32 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

More efficient store contains.

Browse Source
This commit is contained in:
kishorenc 2020-07-14 20:55:10 +05:30
parent f5eb2c164e
commit 66f1f5d01f
2 changed files with 41 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
include/store.h
View File

@ -109,6 +109,19 @@ public:
bool contains(const std::string& key) const {
std::string value;
bool value_found;
bool key_may_exist = db->KeyMayExist(rocksdb::ReadOptions(), key, &value, &value_found);
// returns false when key definitely does not exist
if(!key_may_exist) {
return false;
}
if(value_found) {
return true;
}
// otherwise, we have try getting the value
rocksdb::Status status = db->Get(rocksdb::ReadOptions(), key, &value);
return status.ok() && !status.IsNotFound();
}

28
test/store_test.cpp
View File

@ -137,4 +137,32 @@ TEST(StoreTest, GetUpdateSinceInvalidIterator) {
ASSERT_FALSE(updates_op.ok());
ASSERT_EQ("Invalid iterator. Master's latest sequence number is 4 but updates are requested from sequence number 2. "
"The master's WAL entries might have expired (they are kept only for 24 hours).", updates_op.error());
}
TEST(StoreTest, Contains) {
std::string primary_store_path = "/tmp/typesense_test/primary_store_test";
LOG(INFO) << "Truncating and creating: " << primary_store_path;
system(("rm -rf "+primary_store_path+" && mkdir -p "+primary_store_path).c_str());
// add some records, flush and try to query
Store primary_store(primary_store_path, 0, 0, true); // disable WAL
primary_store.insert("foo1", "bar1");
primary_store.insert("foo2", "bar2");
primary_store.flush();
ASSERT_EQ(true, primary_store.contains("foo1"));
ASSERT_EQ(true, primary_store.contains("foo2"));
ASSERT_EQ(false, primary_store.contains("foo"));
ASSERT_EQ(false, primary_store.contains("foo3"));
// add more records without flushing and query again
primary_store.insert("foo3", "bar1");
primary_store.insert("foo4", "bar2");
primary_store.flush();
ASSERT_EQ(true, primary_store.contains("foo1"));
ASSERT_EQ(true, primary_store.contains("foo3"));
ASSERT_EQ(true, primary_store.contains("foo4"));
ASSERT_EQ(false, primary_store.contains("foo"));
ASSERT_EQ(false, primary_store.contains("foo5"));
}