postgres/typesense
1
0
Fork 0
mirror of https://github.com/typesense/typesense.git synced 2025-05-16 19:55:21 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Geopoint field cannot be a default sorting field.

Browse Source
This commit is contained in:
Kishore Nallan 2022-09-20 15:12:31 +05:30
parent 940c2b982d
commit 4679d298c7
2 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/field.h
View File

@ -322,6 +322,10 @@ struct field {
"` cannot be an optional field.");
}
if(field.is_geopoint()) {
return Option<bool>(400, "Default sorting field cannot be of type geopoint.");
}
found_default_sorting_field = true;
}

28
test/collection_sorting_test.cpp
View File

@ -707,7 +707,35 @@ TEST_F(CollectionSortingTest, GeoPointSorting) {
ASSERT_FALSE(res_op.ok());
ASSERT_STREQ("Could not find a field named `l` in the schema for sorting.", res_op.error().c_str());
// should not allow creation of collection with geo field as default_sorting_field
nlohmann::json schema = R"({
"name": "coll_geo",
"fields": [
{"name": "title", "type": "string"},
{"name": "location", "type": "geopoint" }
],
"default_sorting_field": "location"
})"_json;
auto op = collectionManager.create_collection(schema);
ASSERT_FALSE(op.ok());
ASSERT_EQ("Default sorting field cannot be of type geopoint.", op.error());
schema = R"({
"name": "coll_geo",
"fields": [
{"name": "title", "type": "string"},
{"name": "location", "type": "geopoint[]" }
],
"default_sorting_field": "location"
})"_json;
op = collectionManager.create_collection(schema);
ASSERT_FALSE(op.ok());
ASSERT_EQ("Default sorting field cannot be of type geopoint.", op.error());
collectionManager.drop_collection("coll1");
collectionManager.drop_collection("coll_geo");
}
TEST_F(CollectionSortingTest, GeoPointSortingWithExcludeRadius) {