postgres/typesense
1
0
Fork 0
mirror of https://github.com/typesense/typesense.git synced 2025-05-28 01:30:07 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Use absolute difference when comparing offset lags.

Browse Source
This commit is contained in:
kishorenc 2021-03-03 20:05:56 +05:30
parent b9f3829b43
commit 206f08db6f
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/raft_server.cpp
View File

@ -475,21 +475,26 @@ void ReplicationState::refresh_nodes(const std::string & nodes) {
}
uint64_t leader_seq = std::atoll(api_res.c_str());
if(leader_seq < seq_num) {
LOG(ERROR) << "Leader sequence " << leader_seq << " is less than local sequence " << seq_num;
this->caught_up = false;
return ;
}
const uint64_t seq_diff = leader_seq - seq_num;
// Since leader waits for writes on followers to finish, follower's storage offset could be
// momentarily ahead of the leader's. So we will use std::abs() for checking the difference.
const int64_t seq_diff = std::abs(int64_t(leader_seq) - int64_t(seq_num));
if(seq_diff < CATCHUP_MIN_SEQUENCE_DIFF) {
this->caught_up = true;
return ;
}
// However, if the difference is large, then something is wrong
if(leader_seq < seq_num) {
LOG(ERROR) << "Leader sequence " << leader_seq << " is less than local sequence " << seq_num;
this->caught_up = false;
return ;
}
float seq_progress = (float(seq_num) / leader_seq) * 100;
LOG(INFO) << "Follower progress percentage: " << seq_progress;
this->caught_up = (seq_progress >= catch_up_threshold_percentage);
}
});