postgres/typesense
1
0
Fork 0
mirror of https://github.com/typesense/typesense.git synced 2025-05-23 15:23:40 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

fix the response status for get_override (#1610)

Browse Source
This commit is contained in:
Krunal Gandhi 2024-03-11 08:17:42 +00:00 committed by GitHub
parent c4eb5cc164
commit 0bcc5ed0b0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 34 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core_api.cpp
View File

@ -1799,7 +1799,7 @@ bool get_override(const std::shared_ptr<http_req>& req, const std::shared_ptr<ht
return false;
}
res->set_200(overrides_op.get().to_json());
res->set_200(overrides_op.get().to_json().dump());
return true;
}

34
test/collection_override_test.cpp
View File

@ -4190,4 +4190,36 @@ TEST_F(CollectionOverrideTest, OverridesPagination) {
override_op = coll2->get_overrides(limit, offset);
ASSERT_FALSE(override_op.ok());
ASSERT_EQ("Invalid offset param.", override_op.error());
}
}
TEST_F(CollectionOverrideTest, RetrieveOverideByID) {
Collection *coll2;
std::vector<field> fields = {field("title", field_types::STRING, false),
field("points", field_types::INT32, false)};
coll2 = collectionManager.get_collection("coll2").get();
if (coll2 == nullptr) {
coll2 = collectionManager.create_collection("coll2", 1, fields, "points").get();
}
nlohmann::json override_json = {
{"id", "override"},
{
"rule", {
{"query", "not-found"},
{"match", override_t::MATCH_EXACT}
}
},
{"metadata", { {"foo", "bar"}}},
};
override_json["id"] = override_json["id"].get<std::string>() + "1";
override_t override;
override_t::parse(override_json, "", override);
coll2->add_override(override);
auto op = coll2->get_override("override1");
ASSERT_TRUE(op.ok());
}