mirror of
https://github.com/timescale/timescaledb.git
synced 2025-05-15 01:53:41 +08:00
a6ff7ba6cc
For continuous aggregates with the old-style partial aggregates renaming columns that are not in the group-by clause will generate an error when upgrading to a later version. The reason is that it is implicitly assumed that the name of the column is the same as for the direct view. This holds true for new-style continous aggregates, but is not always true for old-style continuous aggregates. In particular, columns that are not part of the `GROUP BY` clause can have an internally generated name. This commit fixes that by extracting the name of the column from the partial view and use that when renaming the partial view column and the materialized table column.
95 lines
4.0 KiB
PL/PgSQL
95 lines
4.0 KiB
PL/PgSQL
DROP FUNCTION IF EXISTS _timescaledb_internal.time_col_name_for_chunk(name,name);
|
|
DROP FUNCTION IF EXISTS _timescaledb_internal.time_col_type_for_chunk(name,name);
|
|
|
|
-- Handle column renames for continuous aggregates that were not
|
|
-- handled correctly and fix it in the update. We save the information
|
|
-- in a table.
|
|
CREATE TABLE _timescaledb_internal.rename_tables (
|
|
user_view regclass,
|
|
user_column text,
|
|
partial_view regclass,
|
|
partial_column text,
|
|
direct_view regclass,
|
|
direct_column text,
|
|
mat_table regclass,
|
|
hypertable_id int
|
|
);
|
|
|
|
-- Compare the user view and the direct view of each continuous
|
|
-- aggregate to figure out what columns that were renamed on the user
|
|
-- view but which did not propagate to the other objects of the
|
|
-- continuous aggregate since this did not work in previous versions.
|
|
WITH
|
|
objs AS (
|
|
SELECT format('%I.%I', user_view_schema, user_view_name)::regclass AS user_view,
|
|
format('%I.%I', direct_view_schema, direct_view_name)::regclass AS direct_view,
|
|
format('%I.%I', partial_view_schema, partial_view_name)::regclass AS partial_view,
|
|
format('%I.%I', schema_name, table_name)::regclass AS mat_table,
|
|
mat_hypertable_id AS mat_id
|
|
FROM _timescaledb_catalog.continuous_agg
|
|
JOIN _timescaledb_catalog.hypertable ON mat_hypertable_id = id),
|
|
user_view AS (
|
|
SELECT attrelid, attname, attnum, mat_id
|
|
FROM objs, pg_attribute
|
|
WHERE attrelid = objs.user_view),
|
|
partial_view AS (
|
|
SELECT attrelid, attname, attnum, mat_id
|
|
FROM objs, pg_attribute
|
|
WHERE attrelid = objs.partial_view),
|
|
direct_view AS (
|
|
SELECT attrelid, attname, attnum, mat_id
|
|
FROM objs, pg_attribute
|
|
WHERE attrelid = objs.direct_view)
|
|
INSERT INTO _timescaledb_internal.rename_tables
|
|
SELECT (SELECT user_view FROM objs WHERE uv.attrelid = user_view),
|
|
uv.attname AS user_column,
|
|
(SELECT partial_view FROM objs WHERE uv.attrelid = user_view),
|
|
pv.attname AS partial_column,
|
|
(SELECT direct_view FROM objs WHERE uv.attrelid = user_view),
|
|
dv.attname AS direct_column,
|
|
(SELECT mat_table FROM objs WHERE uv.attrelid = user_view),
|
|
(SELECT mat_id FROM objs WHERE uv.attrelid = user_view)
|
|
FROM user_view uv JOIN direct_view dv USING (mat_id, attnum)
|
|
JOIN partial_view pv USING (mat_id, attnum)
|
|
WHERE uv.attname != dv.attname;
|
|
|
|
CREATE PROCEDURE _timescaledb_internal.alter_table_column(cagg regclass, relation regclass, old_column_name name, new_column_name name) AS $$
|
|
BEGIN
|
|
IF old_column_name != new_column_name THEN
|
|
EXECUTE format('ALTER TABLE %s RENAME COLUMN %I TO %I', relation, old_column_name, new_column_name);
|
|
END IF;
|
|
END;
|
|
$$ LANGUAGE plpgsql;
|
|
|
|
-- Rename the columns for all the associated objects for continuous
|
|
-- aggregates that have renamed columns. Also rename the column in the
|
|
-- dimension table.
|
|
DO
|
|
$$
|
|
DECLARE
|
|
user_view regclass;
|
|
user_column name;
|
|
partial_view regclass;
|
|
partial_column name;
|
|
direct_view regclass;
|
|
direct_column name;
|
|
mat_table regclass;
|
|
ht_id int;
|
|
BEGIN
|
|
FOR user_view, user_column, partial_view, partial_column, direct_view, direct_column, mat_table, ht_id IN
|
|
SELECT * FROM _timescaledb_internal.rename_tables
|
|
LOOP
|
|
-- There is no RENAME COLUMN for views, but we can use ALTER TABLE
|
|
-- to rename a column in a view.
|
|
CALL _timescaledb_internal.alter_table_column(user_view, partial_view, partial_column, user_column);
|
|
CALL _timescaledb_internal.alter_table_column(user_view, direct_view, direct_column, user_column);
|
|
CALL _timescaledb_internal.alter_table_column(user_view, mat_table, partial_column, user_column);
|
|
UPDATE _timescaledb_catalog.dimension SET column_name = user_column
|
|
WHERE hypertable_id = ht_id AND column_name = direct_column;
|
|
END LOOP;
|
|
END
|
|
$$;
|
|
|
|
DROP PROCEDURE _timescaledb_internal.alter_table_column;
|
|
DROP TABLE _timescaledb_internal.rename_tables;
|