mirror of
https://github.com/timescale/timescaledb.git
synced 2025-05-14 17:43:34 +08:00
4a17d4c402
Writing a shell script correctly can be hard even for a skilled
programmer. shellcheck is a static analysis tool that helps catch
common errors in shell scripts. We now have 36 executable scripts in
our repository, for which shellcheck reports 126 errors (calculated
like find . -type f -executable -exec bash -c '[ "$(file --brief
--mime-type "$1")" == "text/x-shellscript" ]' sh {} \; -exec shellcheck
-f gcc --exclude=SC2086 {} \; | cut -d: -f1 | sort | uniq | wc -l).
This commit fixes these warnings and adds a GitHub actions workflow
that runs shellcheck on all the executable shell scripts in the
repository. The warning SC2086: Double quote to prevent globbing and
word splitting is disabled globally, because it has little practical
consequences, sometimes leads to false positives, and is general is too
widespread because people forget to quote.
48 lines
1.3 KiB
Bash
Executable File
48 lines
1.3 KiB
Bash
Executable File
#! /bin/bash
|
|
|
|
SCRIPT_DIR=$(dirname ${0})
|
|
SRC_DIR=$(dirname ${SCRIPT_DIR})
|
|
|
|
# we skip license checks for:
|
|
# - the update script fragments, because the generated update scripts will
|
|
# contain the license at top, and we don't want to repeat it in the middle
|
|
# - test/sql/dump which contains auto-generated code
|
|
# - src/chunk_adatptive since it's still in BETA
|
|
|
|
check_file() {
|
|
SUFFIX0=
|
|
SUFFIX1=
|
|
|
|
if [[ ${1} == '-c' || ${1} == '-e' ]]; then
|
|
SUFFIX0='*.c'
|
|
SUFFIX1='*.h'
|
|
elif [[ ${1} == '-i' || ${1} == '-j' ]]; then
|
|
SUFFIX0='*.spec'
|
|
SUFFIX1='*.spec.in'
|
|
elif [[ ${1} == '-p' ]]; then
|
|
SUFFIX0='*.pl'
|
|
SUFFIX1='*.pm'
|
|
else
|
|
SUFFIX0='*.sql'
|
|
SUFFIX1='*.sql.in'
|
|
fi
|
|
|
|
find $2 -type f \( -name "${SUFFIX0}" -or -name "${SUFFIX1}" \) -and -not -path "${SRC_DIR}/sql/updates/*.sql" -and -not -path "${SRC_DIR}/test/sql/dump/*.sql" -and -not -path "${SRC_DIR}/src/chunk_adaptive.*" -print0 | xargs -0 -n1 "$(dirname ${0})/check_file_license.sh" ${1}
|
|
}
|
|
|
|
args=$(getopt "c:e:i:j:p:s:t:" "$@"); set -- $args
|
|
|
|
ERRORCODE=0
|
|
|
|
while [[ ${1} ]]; do
|
|
if [[ ${1} == "--" ]]; then
|
|
break;
|
|
fi
|
|
check_file ${1} ${2}
|
|
FILE_ERR=${?}
|
|
ERRORCODE=$((FILE_ERR | ERRORCODE));
|
|
shift; shift;
|
|
done
|
|
|
|
exit ${ERRORCODE};
|