mirror of
https://github.com/timescale/timescaledb.git
synced 2025-05-16 18:43:18 +08:00
9b91665162
A number of TimescaleDB functions internally call `AlterTableInternal` to modify tables or indexes. For instance, `compress_chunk` and `attach_tablespace` act as DDL commands to modify hypertables. However, crashes occur when these functions are called via `SELECT * INTO FROM <function_name>` or the equivalent `CREATE TABLE AS` statement. The crashes happen because these statements are considered process utility commands and therefore sets up an event trigger context for collecting commands. However, the event trigger context is not properly set up to record alter table statements in this code path, thus causing the crashes. To prevent crashes, wrap `AlterTableInternal` with the event trigger functions to properly initialize the event trigger context.
243 lines
9.8 KiB
SQL
243 lines
9.8 KiB
SQL
-- This file and its contents are licensed under the Apache License 2.0.
|
|
-- Please see the included NOTICE for copyright information and
|
|
-- LICENSE-APACHE for a copy of the license.
|
|
|
|
\set ON_ERROR_STOP 0
|
|
|
|
\c :TEST_DBNAME :ROLE_SUPERUSER
|
|
CREATE VIEW hypertable_tablespaces AS
|
|
SELECT cls.relname AS hypertable,
|
|
(SELECT spcname FROM pg_tablespace WHERE oid = reltablespace) AS tablespace
|
|
FROM _timescaledb_catalog.hypertable,
|
|
LATERAL (SELECT * FROM pg_class WHERE oid = format('%I.%I', schema_name, table_name)::regclass) AS cls
|
|
ORDER BY hypertable, tablespace;
|
|
GRANT SELECT ON hypertable_tablespaces TO PUBLIC;
|
|
|
|
--Test hypertable with tablespace. Tablespaces are cluster-wide, so we
|
|
--attach the test name as prefix to allow tests to be executed in
|
|
--parallel.
|
|
CREATE TABLESPACE tablespace1 OWNER :ROLE_DEFAULT_PERM_USER LOCATION :TEST_TABLESPACE1_PATH;
|
|
\c :TEST_DBNAME :ROLE_DEFAULT_PERM_USER
|
|
|
|
--assigning a tablespace via the main table should work
|
|
CREATE TABLE tspace_2dim(time timestamp, temp float, device text) TABLESPACE tablespace1;
|
|
SELECT create_hypertable('tspace_2dim', 'time', 'device', 2);
|
|
|
|
INSERT INTO tspace_2dim VALUES ('2017-01-20T09:00:01', 24.3, 'blue');
|
|
|
|
-- Tablespace for tspace_2dim should be set
|
|
SELECT * FROM hypertable_tablespaces WHERE hypertable = 'tspace_2dim';
|
|
SELECT show_tablespaces('tspace_2dim');
|
|
|
|
--verify that the table chunk has the correct tablespace
|
|
SELECT relname, spcname FROM pg_class c
|
|
INNER JOIN pg_tablespace t ON (c.reltablespace = t.oid)
|
|
INNER JOIN _timescaledb_catalog.chunk ch ON (ch.table_name = c.relname);
|
|
|
|
--check some error conditions
|
|
SELECT attach_tablespace(NULL,NULL);
|
|
SELECT attach_tablespace('tablespace2', NULL);
|
|
SELECT attach_tablespace(NULL, 'tspace_2dim');
|
|
SELECT attach_tablespace('none_existing_tablespace', 'tspace_2dim');
|
|
SELECT attach_tablespace('tablespace2', 'none_existing_table');
|
|
SELECT detach_tablespace(NULL);
|
|
SELECT detach_tablespaces(NULL);
|
|
SELECT show_tablespaces(NULL);
|
|
|
|
--attach another tablespace without first creating it --> should generate error
|
|
SELECT attach_tablespace('tablespace2', 'tspace_2dim');
|
|
--attach the same tablespace twice to same table should also generate error
|
|
SELECT attach_tablespace('tablespace1', 'tspace_2dim');
|
|
|
|
--no error if if_not_attached is given
|
|
SELECT attach_tablespace('tablespace1', 'tspace_2dim', if_not_attached => true);
|
|
|
|
\c :TEST_DBNAME :ROLE_SUPERUSER
|
|
--Tablespaces are cluster-wide, so we attach the test name as prefix
|
|
--to allow tests to be executed in parallel.
|
|
CREATE TABLESPACE tablespace2 OWNER :ROLE_DEFAULT_PERM_USER_2 LOCATION :TEST_TABLESPACE2_PATH;
|
|
\c :TEST_DBNAME :ROLE_DEFAULT_PERM_USER_2
|
|
|
|
--attach without permissions on the table should fail
|
|
SELECT attach_tablespace('tablespace2', 'tspace_2dim');
|
|
|
|
\c :TEST_DBNAME :ROLE_DEFAULT_PERM_USER
|
|
|
|
--attach without permissions on the tablespace should also fail
|
|
SELECT attach_tablespace('tablespace2', 'tspace_2dim');
|
|
|
|
\c :TEST_DBNAME :ROLE_SUPERUSER
|
|
GRANT :ROLE_DEFAULT_PERM_USER_2 TO :ROLE_DEFAULT_PERM_USER;
|
|
\c :TEST_DBNAME :ROLE_DEFAULT_PERM_USER
|
|
|
|
--should work with permissions on both the table and the tablespace
|
|
SELECT attach_tablespace('tablespace2', 'tspace_2dim');
|
|
|
|
SELECT * FROM _timescaledb_catalog.tablespace;
|
|
SELECT * FROM show_tablespaces('tspace_2dim');
|
|
|
|
--insert into another chunk
|
|
INSERT INTO tspace_2dim VALUES ('2017-01-20T09:00:01', 24.3, 'brown');
|
|
|
|
SELECT * FROM test.show_subtables('tspace_2dim');
|
|
|
|
--indexes should inherit the tablespace of their chunk
|
|
SELECT * FROM test.show_indexesp('_timescaledb_internal._hyper%_chunk');
|
|
|
|
\x
|
|
SELECT * FROM timescaledb_information.hypertables
|
|
ORDER BY hypertable_schema, hypertable_name;
|
|
SELECT * FROM timescaledb_information.chunks ORDER BY chunk_name;
|
|
\x
|
|
--
|
|
SET ROLE :ROLE_DEFAULT_PERM_USER_2;
|
|
CREATE TABLE tspace_1dim(time timestamp, temp float, device text);
|
|
SELECT create_hypertable('tspace_1dim', 'time');
|
|
--user doesn't have permission on tablespace1 --> error
|
|
SELECT attach_tablespace('tablespace1', 'tspace_1dim');
|
|
|
|
--grant permission to tablespace1
|
|
SET ROLE :ROLE_DEFAULT_PERM_USER;
|
|
GRANT CREATE ON TABLESPACE tablespace1 TO :ROLE_DEFAULT_PERM_USER_2;
|
|
SET ROLE :ROLE_DEFAULT_PERM_USER_2;
|
|
--should work fine now. Test SELECT INTO utility statements to ensure
|
|
--internal alter table function call works with event triggers.
|
|
SELECT true INTO attached FROM attach_tablespace('tablespace1', 'tspace_1dim');
|
|
SELECT attach_tablespace('tablespace2', 'tspace_1dim');
|
|
-- Tablespace for tspace_1dim should be set and attached
|
|
SELECT * FROM hypertable_tablespaces WHERE hypertable = 'tspace_1dim';
|
|
SELECT show_tablespaces('tspace_1dim');
|
|
|
|
--trying to revoke permissions while attached should fail
|
|
SET ROLE :ROLE_DEFAULT_PERM_USER;
|
|
REVOKE CREATE ON TABLESPACE tablespace1 FROM :ROLE_DEFAULT_PERM_USER_2;
|
|
REVOKE ALL ON TABLESPACE tablespace1 FROM :ROLE_DEFAULT_PERM_USER_2;
|
|
SET ROLE :ROLE_DEFAULT_PERM_USER_2;
|
|
|
|
SELECT * FROM _timescaledb_catalog.tablespace;
|
|
|
|
INSERT INTO tspace_1dim VALUES ('2017-01-20T09:00:01', 24.3, 'blue');
|
|
INSERT INTO tspace_1dim VALUES ('2017-03-20T09:00:01', 24.3, 'brown');
|
|
|
|
SELECT * FROM test.show_subtablesp('tspace_%');
|
|
--indexes should inherit the tablespace of their chunk, unless the
|
|
--parent index has a tablespace set, in which case the chunks'
|
|
--corresponding indexes are pinned to the parent index's
|
|
--tablespace. The parent index can have a tablespace set in two cases:
|
|
--(1) if explicitly set in CREATE INDEX, or (2) if the main table was
|
|
--created with a tablespace, because then default indexes will be
|
|
--created in that tablespace too.
|
|
SELECT * FROM test.show_indexesp('_timescaledb_internal._hyper%_chunk');
|
|
|
|
--detach tablespace1 from tspace_2dim should fail due to lack of permissions
|
|
SELECT detach_tablespace('tablespace1', 'tspace_2dim');
|
|
--detach tablespace1 from all tables. Should only detach from
|
|
--'tspace_1dim' (1 tablespace) due to lack of permissions
|
|
SELECT * FROM hypertable_tablespaces;
|
|
SELECT * INTO detached FROM detach_tablespace('tablespace1');
|
|
SELECT * FROM detached;
|
|
SELECT * FROM _timescaledb_catalog.tablespace;
|
|
SELECT * FROM show_tablespaces('tspace_1dim');
|
|
SELECT * FROM show_tablespaces('tspace_2dim');
|
|
SELECT * FROM hypertable_tablespaces;
|
|
|
|
--it should now be possible to revoke permissions on tablespace1
|
|
SET ROLE :ROLE_DEFAULT_PERM_USER;
|
|
REVOKE CREATE ON TABLESPACE tablespace1 FROM :ROLE_DEFAULT_PERM_USER_2;
|
|
SET ROLE :ROLE_DEFAULT_PERM_USER_2;
|
|
|
|
--detach the other tablespace
|
|
SELECT detach_tablespace('tablespace2', 'tspace_1dim');
|
|
SELECT * FROM _timescaledb_catalog.tablespace;
|
|
SELECT * FROM show_tablespaces('tspace_1dim');
|
|
SELECT * FROM show_tablespaces('tspace_2dim');
|
|
SELECT * FROM hypertable_tablespaces;
|
|
|
|
--detaching tablespace2 from a table without permissions should fail
|
|
SELECT detach_tablespace('tablespace2', 'tspace_2dim');
|
|
SELECT detach_tablespaces('tspace_2dim');
|
|
|
|
\c :TEST_DBNAME :ROLE_SUPERUSER
|
|
-- PERM_USER_2 owns tablespace2, and PERM_USER owns the table
|
|
-- 'tspace_2dim', which has tablespace2 attached. Revoking PERM_USER_2
|
|
-- FROM PERM_USER should therefore fail
|
|
REVOKE :ROLE_DEFAULT_PERM_USER_2 FROM :ROLE_DEFAULT_PERM_USER;
|
|
SET ROLE :ROLE_DEFAULT_PERM_USER_2;
|
|
|
|
--set other user should make detach work
|
|
SET ROLE :ROLE_DEFAULT_PERM_USER;
|
|
SELECT * INTO detached_all FROM detach_tablespaces('tspace_2dim');
|
|
SELECT * FROM detached_all;
|
|
SELECT * FROM _timescaledb_catalog.tablespace;
|
|
SELECT * FROM show_tablespaces('tspace_1dim');
|
|
SELECT * FROM show_tablespaces('tspace_2dim');
|
|
|
|
\c :TEST_DBNAME :ROLE_SUPERUSER
|
|
-- It should now be possible to revoke PERM_USER_2 from PERM_USER
|
|
-- since tablespace2 is no longer attched to tspace_2dim
|
|
REVOKE :ROLE_DEFAULT_PERM_USER_2 FROM :ROLE_DEFAULT_PERM_USER;
|
|
SET ROLE :ROLE_DEFAULT_PERM_USER;
|
|
|
|
--detaching twice should fail
|
|
SELECT detach_tablespace('tablespace2', 'tspace_2dim');
|
|
--adding if_attached should only generate notice
|
|
SELECT detach_tablespace('tablespace2', 'tspace_2dim', if_attached => true);
|
|
|
|
--attach tablespaces again to verify that tablespaces are cleaned up
|
|
--when tables are dropped
|
|
\c :TEST_DBNAME :ROLE_SUPERUSER
|
|
SELECT attach_tablespace('tablespace2', 'tspace_1dim');
|
|
SELECT attach_tablespace('tablespace1', 'tspace_2dim');
|
|
|
|
SELECT * FROM _timescaledb_catalog.tablespace;
|
|
DROP TABLE tspace_1dim;
|
|
SELECT * FROM _timescaledb_catalog.tablespace;
|
|
DROP TABLE tspace_2dim;
|
|
SELECT * FROM _timescaledb_catalog.tablespace;
|
|
|
|
-- Create two tables and attach multiple tablespaces to them. Verify
|
|
-- that dropping a tablespace from multiple tables work as expected.
|
|
CREATE TABLE tbl_1(time timestamp, temp float, device text);
|
|
SELECT create_hypertable('tbl_1', 'time');
|
|
CREATE TABLE tbl_2(time timestamp, temp float, device text);
|
|
SELECT create_hypertable('tbl_2', 'time');
|
|
CREATE TABLE tbl_3(time timestamp, temp float, device text);
|
|
SELECT create_hypertable('tbl_3', 'time');
|
|
SELECT * FROM hypertable_tablespaces;
|
|
SELECT * FROM show_tablespaces('tbl_1');
|
|
SELECT * FROM show_tablespaces('tbl_2');
|
|
SELECT * FROM show_tablespaces('tbl_3');
|
|
|
|
SELECT attach_tablespace('tablespace1', 'tbl_1');
|
|
SELECT attach_tablespace('tablespace2', 'tbl_1');
|
|
SELECT attach_tablespace('tablespace2', 'tbl_2');
|
|
SELECT attach_tablespace('tablespace2', 'tbl_3');
|
|
SELECT * FROM hypertable_tablespaces;
|
|
SELECT * FROM show_tablespaces('tbl_1');
|
|
SELECT * FROM show_tablespaces('tbl_2');
|
|
SELECT * FROM show_tablespaces('tbl_3');
|
|
|
|
SELECT detach_tablespace('tablespace2');
|
|
SELECT * FROM hypertable_tablespaces;
|
|
SELECT * FROM show_tablespaces('tbl_1');
|
|
SELECT * FROM show_tablespaces('tbl_2');
|
|
SELECT * FROM show_tablespaces('tbl_3');
|
|
|
|
DROP TABLE tbl_1;
|
|
DROP TABLE tbl_2;
|
|
DROP TABLE tbl_3;
|
|
|
|
-- verify that one cannot DROP a tablespace while it is attached to a
|
|
-- hypertable
|
|
CREATE TABLE tbl_1(time timestamp, temp float, device text);
|
|
|
|
SELECT create_hypertable('tbl_1', 'time');
|
|
SELECT attach_tablespace('tablespace1', 'tbl_1');
|
|
SELECT * FROM show_tablespaces('tbl_1');
|
|
|
|
DROP TABLESPACE tablespace1;
|
|
--after detaching we should now be able to drop the tablespace
|
|
SELECT detach_tablespace('tablespace1', 'tbl_1');
|
|
DROP TABLESPACE tablespace1;
|
|
DROP TABLESPACE tablespace2;
|