mirror of
https://github.com/timescale/timescaledb.git
synced 2025-05-16 10:33:27 +08:00
839e42dd0c
PG15 introduced a ProcSignalBarrier mechanism in drop database implementation to force all backends to close the file handles for dropped tables. The backend that is executing the drop database command will emit a new process signal barrier and wait for other backends to accept it. But the backend which is executing the delete_data_node function will not be able to process the above mentioned signal as it will be stuck waiting for the drop database query to return. Thus the two backends end up waiting for each other causing a deadlock. Fixed it by using the async API to execute the drop database command from delete_data_node instead of the blocking remote_connection_cmdf_ok call. Fixes #4838
291 lines
11 KiB
Python
Executable File
291 lines
11 KiB
Python
Executable File
#!/usr/bin/env python
|
|
|
|
# This file and its contents are licensed under the Apache License 2.0.
|
|
# Please see the included NOTICE for copyright information and
|
|
# LICENSE-APACHE for a copy of the license.
|
|
|
|
# Python script to dynamically generate matrix for github action
|
|
|
|
# Since we want to run additional test configurations when triggered
|
|
# by a push to prerelease_test or by cron but github actions don't
|
|
# allow a dynamic matrix via yaml configuration, we generate the matrix
|
|
# with this python script. While we could always have the full matrix
|
|
# and have if checks on every step that would make the actual checks
|
|
# harder to browse because the workflow will have lots of entries and
|
|
# only by navigating into the individual jobs would it be visible
|
|
# if a job was actually run.
|
|
|
|
import json
|
|
import os
|
|
import subprocess
|
|
import sys
|
|
from ci_settings import (
|
|
PG12_EARLIEST,
|
|
PG12_LATEST,
|
|
PG13_EARLIEST,
|
|
PG13_LATEST,
|
|
PG14_EARLIEST,
|
|
PG14_LATEST,
|
|
)
|
|
|
|
# github event type which is either push, pull_request or schedule
|
|
event_type = sys.argv[1]
|
|
|
|
m = {
|
|
"include": [],
|
|
}
|
|
|
|
# helper functions to generate matrix entries
|
|
# the release and apache config inherit from the
|
|
# debug config to reduce repetition
|
|
def build_debug_config(overrides):
|
|
# llvm version and clang versions must match otherwise
|
|
# there will be build errors this is true even when compiling
|
|
# with gcc as clang is used to compile the llvm parts.
|
|
#
|
|
# Strictly speaking, WARNINGS_AS_ERRORS=ON is not needed here, but
|
|
# we add it as a precaution. Intention is to have at least one
|
|
# release and one debug build with WARNINGS_AS_ERRORS=ON so that we
|
|
# capture warnings generated due to changes in the code base or the
|
|
# compiler.
|
|
base_config = dict(
|
|
{
|
|
"build_type": "Debug",
|
|
"cc": "gcc",
|
|
"clang": "clang-14",
|
|
"coverage": True,
|
|
"cxx": "g++",
|
|
"extra_packages": "clang-14 llvm-14 llvm-14-dev llvm-14-tools",
|
|
"installcheck_args": "IGNORES='bgw_db_scheduler bgw_db_scheduler_fixed'",
|
|
"name": "Debug",
|
|
"os": "ubuntu-22.04",
|
|
"pg_extra_args": "--enable-debug --enable-cassert --with-llvm LLVM_CONFIG=llvm-config-14",
|
|
"pginstallcheck": True,
|
|
"tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DREQUIRE_ALL_TESTS=ON",
|
|
}
|
|
)
|
|
base_config.update(overrides)
|
|
return base_config
|
|
|
|
|
|
# We build this release configuration with WARNINGS_AS_ERRORS=ON to
|
|
# make sure that we can build with -Werrors even for release
|
|
# builds. This will capture some cases where warnings are generated
|
|
# for release builds but not for debug builds.
|
|
def build_release_config(overrides):
|
|
base_config = build_debug_config({})
|
|
release_config = dict(
|
|
{
|
|
"name": "Release",
|
|
"build_type": "Release",
|
|
"tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DREQUIRE_ALL_TESTS=ON",
|
|
"coverage": False,
|
|
}
|
|
)
|
|
base_config.update(release_config)
|
|
base_config.update(overrides)
|
|
return base_config
|
|
|
|
|
|
def build_without_telemetry(overrides):
|
|
config = build_release_config({})
|
|
config.update(
|
|
{
|
|
"name": "ReleaseWithoutTelemetry",
|
|
"tsdb_build_args": config["tsdb_build_args"] + " -DUSE_TELEMETRY=OFF",
|
|
"coverage": False,
|
|
}
|
|
)
|
|
config.update(overrides)
|
|
return config
|
|
|
|
|
|
def build_apache_config(overrides):
|
|
base_config = build_debug_config({})
|
|
apache_config = dict(
|
|
{
|
|
"name": "ApacheOnly",
|
|
"build_type": "Release",
|
|
"tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DREQUIRE_ALL_TESTS=ON -DAPACHE_ONLY=1",
|
|
"coverage": False,
|
|
}
|
|
)
|
|
base_config.update(apache_config)
|
|
base_config.update(overrides)
|
|
return base_config
|
|
|
|
|
|
def macos_config(overrides):
|
|
base_config = dict(
|
|
{
|
|
"cc": "clang",
|
|
"clang": "clang",
|
|
"coverage": False,
|
|
"cxx": "clang++",
|
|
"extra_packages": "",
|
|
"installcheck_args": "IGNORES='bgw_db_scheduler bgw_db_scheduler_fixed bgw_launcher pg_dump remote_connection compressed_collation'",
|
|
"os": "macos-11",
|
|
"pg": PG12_LATEST,
|
|
"pg_extra_args": "--with-libraries=/usr/local/opt/openssl/lib --with-includes=/usr/local/opt/openssl/include",
|
|
"pginstallcheck": True,
|
|
"tsdb_build_args": "-DASSERTIONS=ON -DREQUIRE_ALL_TESTS=ON -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl",
|
|
}
|
|
)
|
|
base_config.update(overrides)
|
|
return base_config
|
|
|
|
|
|
# always test debug build on latest of all supported pg versions
|
|
m["include"].append(build_debug_config({"pg": PG12_LATEST}))
|
|
m["include"].append(
|
|
build_debug_config({"pg": PG13_LATEST, "cc": "clang-14", "cxx": "clang++-14"})
|
|
)
|
|
m["include"].append(build_debug_config({"pg": PG14_LATEST}))
|
|
|
|
m["include"].append(build_release_config(macos_config({})))
|
|
|
|
m["include"].append(build_without_telemetry({"pg": PG14_LATEST}))
|
|
|
|
m["include"].append(
|
|
build_debug_config(
|
|
{
|
|
"pg": 15,
|
|
"snapshot": "snapshot",
|
|
"tsdb_build_args": "-DASSERTIONS=ON -DREQUIRE_ALL_TESTS=ON -DEXPERIMENTAL=ON",
|
|
# below tests are tracked as part of #4838
|
|
"installcheck_args": "SKIPS='003_connections_privs 001_simple_multinode 004_multinode_rdwr_1pc dist_hypertable-15 bgw_custom cagg_dump dist_move_chunk' "
|
|
# below tests are tracked as part of #4835
|
|
"IGNORES='telemetry_stats dist_query dist_partial_agg plan_hashagg partialize_finalize dist_fetcher_type dist_remote_error jit-15 "
|
|
# below tests are tracked as part of #4837
|
|
"remote_txn'",
|
|
}
|
|
)
|
|
)
|
|
|
|
# if this is not a pull request e.g. a scheduled run or a push
|
|
# to a specific branch like prerelease_test we add additional
|
|
# entries to the matrix
|
|
if event_type != "pull_request":
|
|
# add debug test for first supported PG12 version
|
|
# most of the IGNORES are the isolation tests because the output format has changed between versions
|
|
# chunk_utils, telemetry and tablespace are skipped because of use after free bugs in postgres 12.0 which those tests hit
|
|
pg12_debug_earliest = {
|
|
"pg": PG12_EARLIEST,
|
|
# The early releases don't build with llvm 14.
|
|
"pg_extra_args": "--enable-debug --enable-cassert --without-llvm",
|
|
"installcheck_args": "SKIPS='chunk_utils tablespace telemetry' IGNORES='cluster-12 cagg_policy debug_notice dist_gapfill_pushdown-12'",
|
|
"tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DASSERTIONS=ON -DPG_ISOLATION_REGRESS=OFF",
|
|
}
|
|
m["include"].append(build_debug_config(pg12_debug_earliest))
|
|
|
|
# add debug test for first supported PG13 version
|
|
pg13_debug_earliest = {
|
|
"pg": PG13_EARLIEST,
|
|
# The early releases don't build with llvm 14.
|
|
"pg_extra_args": "--enable-debug --enable-cassert --without-llvm",
|
|
"installcheck_args": "SKIPS='001_extension' IGNORES='dist_gapfill_pushdown-13'",
|
|
"tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DASSERTIONS=ON -DPG_ISOLATION_REGRESS=OFF",
|
|
}
|
|
m["include"].append(build_debug_config(pg13_debug_earliest))
|
|
|
|
# add debug test for first supported PG14 version
|
|
m["include"].append(
|
|
build_debug_config(
|
|
{
|
|
"pg": PG14_EARLIEST,
|
|
# The early releases don't build with llvm 14.
|
|
"pg_extra_args": "--enable-debug --enable-cassert --without-llvm",
|
|
"installcheck_args": "IGNORES='dist_gapfill_pushdown-14 memoize'",
|
|
}
|
|
)
|
|
)
|
|
|
|
# add debug test for MacOS
|
|
m["include"].append(build_debug_config(macos_config({})))
|
|
|
|
# add release test for latest pg 12 and 13
|
|
m["include"].append(build_release_config({"pg": PG12_LATEST}))
|
|
m["include"].append(build_release_config({"pg": PG13_LATEST}))
|
|
m["include"].append(build_release_config({"pg": PG14_LATEST}))
|
|
|
|
# add apache only test for latest pg
|
|
m["include"].append(build_apache_config({"pg": PG12_LATEST}))
|
|
m["include"].append(build_apache_config({"pg": PG13_LATEST}))
|
|
m["include"].append(build_apache_config({"pg": PG14_LATEST}))
|
|
|
|
# to discover issues with upcoming releases we run CI against
|
|
# the stable branches of supported PG releases
|
|
m["include"].append(build_debug_config({"pg": 12, "snapshot": "snapshot"}))
|
|
m["include"].append(build_debug_config({"pg": 13, "snapshot": "snapshot"}))
|
|
m["include"].append(
|
|
build_debug_config(
|
|
{
|
|
"installcheck_args": "IGNORES='dist_gapfill_pushdown-14 memoize'",
|
|
"pg": 14,
|
|
"snapshot": "snapshot",
|
|
}
|
|
)
|
|
)
|
|
else:
|
|
# Check if we need to check for the flaky tests. Determine which test files
|
|
# have been changed in the PR. The sql files might include other files that
|
|
# change independently, and might be .in templates, so it's easier to look
|
|
# at the output files. They are also the same for the isolation tests.
|
|
p = subprocess.Popen(
|
|
f"git diff --name-only {sys.argv[2]} -- '**expected/*.out'",
|
|
stdout=subprocess.PIPE,
|
|
shell=True,
|
|
)
|
|
(output, err) = p.communicate()
|
|
p_status = p.wait()
|
|
if p_status != 0:
|
|
print(
|
|
f'git diff failed: code {p_status}, output "{output}", stderr "{err}"',
|
|
file=sys.stderr,
|
|
)
|
|
sys.exit(1)
|
|
tests = set()
|
|
test_count = 1
|
|
for f in output.decode().split("\n"):
|
|
print(f)
|
|
if not f:
|
|
continue
|
|
test_count += 1
|
|
if test_count > 10:
|
|
print(
|
|
f"too many ({test_count}) changed tests, won't run the flaky check",
|
|
file=sys.stderr,
|
|
)
|
|
print("full list:", file=sys.stderr)
|
|
print(output, file=sys.stderr)
|
|
tests = set()
|
|
break
|
|
basename = os.path.basename(f)
|
|
splitted = basename.split(".")
|
|
name = splitted[0]
|
|
ext = splitted[-1]
|
|
if ext == "out":
|
|
# Account for the version number.
|
|
tests.add(name)
|
|
else:
|
|
# Should've been filtered out above.
|
|
print(f"unknown extension '{ext}' for test output file '{f}'", file=sys.stderr)
|
|
sys.exit(1)
|
|
|
|
if tests:
|
|
m["include"].append(
|
|
build_debug_config(
|
|
{
|
|
"coverage": False,
|
|
"installcheck_args": f'TESTS="{" ".join(list(tests) * 20)}"',
|
|
"name": "Flaky Check Debug",
|
|
"pg": PG14_LATEST,
|
|
"pginstallcheck": False,
|
|
}
|
|
)
|
|
)
|
|
|
|
# generate command to set github action variable
|
|
with open(os.environ["GITHUB_OUTPUT"], "a") as output:
|
|
print(str.format("matrix={0}", json.dumps(m)), file=output)
|