postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-17 19:13:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fail continuous aggregate refresh smaller than one bucket

Browse Source 
When refreshing a continuous aggregate, we only materialize the
buckets that are fully enclosed by the refresh window. Therefore, we
should generate an error if the window is smaller than one bucket.
This commit is contained in:
Erik Nordström 2021-02-11 09:13:27 +01:00 committed by Erik Nordström
parent 3b42300407
commit ff7fb0aedf
3 changed files with 76 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tsl/src/continuous_aggs/refresh.c
View File

@ -475,14 +475,17 @@ continuous_agg_refresh_internal(const ContinuousAgg *cagg,
* prevent transaction blocks. */
PreventInTransactionBlock(true, REFRESH_FUNCTION_NAME);
if (refresh_window_arg->start >= refresh_window_arg->end)
ereport(ERROR,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("invalid refresh window"),
errhint("The start of the window must be before the end.")));
refresh_window =
compute_inscribed_bucketed_refresh_window(refresh_window_arg, cagg->data.bucket_width);
if (refresh_window.start >= refresh_window.end)
ereport(ERROR,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("refresh window too small"),
errdetail("The refresh window must cover at least one bucket of data."),
errhint("Align the refresh window with the bucket"
" time zone or use at least two buckets.")));
log_refresh_window(DEBUG1, cagg, &refresh_window, "refreshing continuous aggregate");
/* Perform the refresh across two transactions.

42
tsl/test/expected/continuous_aggs_refresh.out
View File

@ -58,6 +58,46 @@ ORDER BY day DESC, device;
-----+--------+----------
(0 rows)
-- Refresh one bucket (1 day):
SHOW timezone;
TimeZone
----------
PST8PDT
(1 row)
-- The refresh of a single bucket must align with the start of the day
-- in the bucket's time zone (which is UTC, since time_bucket doesn't
-- support time zone arg)
CALL refresh_continuous_aggregate('daily_temp', '2020-05-03 00:00 UTC', '2020-05-04 00:00 UTC');
CALL refresh_continuous_aggregate('daily_temp', '2020-05-03 17:00 PDT', '2020-05-04 17:00 PDT');
\set ON_ERROR_STOP 0
\set VERBOSITY default
-- These refreshes will fail since they don't align with the bucket's
-- time zone
CALL refresh_continuous_aggregate('daily_temp', '2020-05-03', '2020-05-04');
ERROR: refresh window too small
DETAIL: The refresh window must cover at least one bucket of data.
HINT: Align the refresh window with the bucket time zone or use at least two buckets.
CALL refresh_continuous_aggregate('daily_temp', '2020-05-03 00:00 PDT', '2020-05-04 00:00 PDT');
ERROR: refresh window too small
DETAIL: The refresh window must cover at least one bucket of data.
HINT: Align the refresh window with the bucket time zone or use at least two buckets.
-- Refresh window less than one bucket
CALL refresh_continuous_aggregate('daily_temp', '2020-05-03 00:00 UTC', '2020-05-03 23:59 UTC');
ERROR: refresh window too small
DETAIL: The refresh window must cover at least one bucket of data.
HINT: Align the refresh window with the bucket time zone or use at least two buckets.
-- Refresh window bigger than one bucket, but failing since it is not
-- aligned with bucket boundaries so that it covers a full bucket:
--
-- Refresh window: [----------)
-- Buckets: [------|------]
CALL refresh_continuous_aggregate('daily_temp', '2020-05-03 01:00 UTC', '2020-05-04 08:00 UTC');
ERROR: refresh window too small
DETAIL: The refresh window must cover at least one bucket of data.
HINT: Align the refresh window with the bucket time zone or use at least two buckets.
\set VERBOSITY terse
\set ON_ERROR_STOP 1
-- Refresh the most recent few days:
CALL refresh_continuous_aggregate('daily_temp', '2020-05-02', '2020-05-05 17:00');
SELECT * FROM daily_temp
@ -176,7 +216,7 @@ ERROR: invalid input syntax for type timestamp with time zone: "xyz"
CALL refresh_continuous_aggregate('daily_temp', '2020-05-03', 'xyz');
ERROR: invalid input syntax for type timestamp with time zone: "xyz"
CALL refresh_continuous_aggregate('daily_temp', '2020-05-03', '2020-05-01');
ERROR: invalid refresh window
ERROR: refresh window too small
-- Bad time input
CALL refresh_continuous_aggregate('daily_temp', '2020-05-01'::text, '2020-05-03'::text);
ERROR: invalid time argument type "text"

26
tsl/test/sql/continuous_aggs_refresh.sql
View File

@ -33,6 +33,32 @@ GROUP BY 1,2 WITH NO DATA;
SELECT * FROM daily_temp
ORDER BY day DESC, device;
-- Refresh one bucket (1 day):
SHOW timezone;
-- The refresh of a single bucket must align with the start of the day
-- in the bucket's time zone (which is UTC, since time_bucket doesn't
-- support time zone arg)
CALL refresh_continuous_aggregate('daily_temp', '2020-05-03 00:00 UTC', '2020-05-04 00:00 UTC');
CALL refresh_continuous_aggregate('daily_temp', '2020-05-03 17:00 PDT', '2020-05-04 17:00 PDT');
\set ON_ERROR_STOP 0
\set VERBOSITY default
-- These refreshes will fail since they don't align with the bucket's
-- time zone
CALL refresh_continuous_aggregate('daily_temp', '2020-05-03', '2020-05-04');
CALL refresh_continuous_aggregate('daily_temp', '2020-05-03 00:00 PDT', '2020-05-04 00:00 PDT');
-- Refresh window less than one bucket
CALL refresh_continuous_aggregate('daily_temp', '2020-05-03 00:00 UTC', '2020-05-03 23:59 UTC');
-- Refresh window bigger than one bucket, but failing since it is not
-- aligned with bucket boundaries so that it covers a full bucket:
--
-- Refresh window: [----------)
-- Buckets: [------|------]
CALL refresh_continuous_aggregate('daily_temp', '2020-05-03 01:00 UTC', '2020-05-04 08:00 UTC');
\set VERBOSITY terse
\set ON_ERROR_STOP 1
-- Refresh the most recent few days:
CALL refresh_continuous_aggregate('daily_temp', '2020-05-02', '2020-05-05 17:00');