postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-21 13:14:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix assertion in calculate_chunk_interval for negative target size

Browse Source 
When called with negative chunk_target_size_bytes
calculate_chunk_interval will throw an assertion. This patch adds
error handling for this condition. Found by sqlsmith.
This commit is contained in:
Sven Klemm 2023-03-07 11:29:52 +01:00 committed by Sven Klemm
parent 00321dba41
commit f680b99529
3 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/chunk_adaptive.c
View File

@ -429,7 +429,9 @@ ts_calculate_chunk_interval(PG_FUNCTION_ARGS)
if (PG_NARGS() != CHUNK_SIZING_FUNC_NARGS)
elog(ERROR, "invalid number of arguments");
Assert(chunk_target_size_bytes >= 0);
if (chunk_target_size_bytes < 0)
elog(ERROR, "chunk_target_size must be positive");
elog(DEBUG1, "[adaptive] chunk_target_size_bytes=" UINT64_FORMAT, chunk_target_size_bytes);
hypertable_id = ts_dimension_get_hypertable_id(dimension_id);

7
test/expected/chunk_adaptive.out
View File

@ -1,6 +1,13 @@
-- This file and its contents are licensed under the Apache License 2.0.
-- Please see the included NOTICE for copyright information and
-- LICENSE-APACHE for a copy of the license.
-- test error handling _timescaledb_internal.calculate_chunk_interval
\set ON_ERROR_STOP 0
SELECT _timescaledb_internal.calculate_chunk_interval(0,0,-0);
ERROR: could not find a matching hypertable for dimension 0
SELECT _timescaledb_internal.calculate_chunk_interval(1,0,-1);
ERROR: chunk_target_size must be positive
\set ON_ERROR_STOP 1
-- Valid chunk sizing function for testing
CREATE OR REPLACE FUNCTION calculate_chunk_interval(
dimension_id INTEGER,

6
test/sql/chunk_adaptive.sql
View File

@ -2,6 +2,12 @@
-- Please see the included NOTICE for copyright information and
-- LICENSE-APACHE for a copy of the license.
-- test error handling _timescaledb_internal.calculate_chunk_interval
\set ON_ERROR_STOP 0
SELECT _timescaledb_internal.calculate_chunk_interval(0,0,-0);
SELECT _timescaledb_internal.calculate_chunk_interval(1,0,-1);
\set ON_ERROR_STOP 1
-- Valid chunk sizing function for testing
CREATE OR REPLACE FUNCTION calculate_chunk_interval(
dimension_id INTEGER,