postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-28 09:46:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add primnodes.h to ts_get_node_name function

Browse Source 
In partitioning.c the function `resolve_function_argtype` deal with
some primitive nodes in order to resolve the argument type for hashing
functions.

Refactoring the code a bit and added the primitive nodes (primnodes.h)
to the `ts_get_node_name` and improve the error message of
`resolve_function_argtype` showing the name of the node type instead of
the code when an unsupported node type is detected.
This commit is contained in:
Fabrízio de Royes Mello 2022-08-08 10:36:07 -03:00
parent 5c129be60f
commit ea7a9db972
2 changed files with 62 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/partitioning.c
View File

@ -305,23 +305,23 @@ resolve_function_argtype(FunctionCallInfo fcinfo)
switch (nodeTag(node))
{
case T_Var:
argtype = ((Var *) node)->vartype;
argtype = castNode(Var, node)->vartype;
break;
case T_Const:
argtype = ((Const *) node)->consttype;
argtype = castNode(Const, node)->consttype;
break;
case T_CoerceViaIO:
argtype = ((CoerceViaIO *) node)->resulttype;
argtype = castNode(CoerceViaIO, node)->resulttype;
break;
case T_FuncExpr:
/* Argument is function, so our input is its result type */
argtype = ((FuncExpr *) node)->funcresulttype;
argtype = castNode(FuncExpr, node)->funcresulttype;
break;
case T_Param:
argtype = ((Param *) node)->paramtype;
argtype = castNode(Param, node)->paramtype;
break;
default:
elog(ERROR, "unsupported expression argument node type %u", nodeTag(node));
elog(ERROR, "unsupported expression argument node type: %s", ts_get_node_name(node));
}
return argtype;

56
src/utils.c
View File

@ -993,6 +993,62 @@ ts_get_node_name(Node *node)
/* tags are defined in nodes/nodes.h postgres source */
switch (nodeTag(node))
{
/*
* primitive nodes (primnodes.h)
*/
NODE_CASE(Alias);
NODE_CASE(RangeVar);
NODE_CASE(TableFunc);
NODE_CASE(IntoClause);
NODE_CASE(Expr);
NODE_CASE(Var);
NODE_CASE(Const);
NODE_CASE(Param);
NODE_CASE(Aggref);
NODE_CASE(GroupingFunc);
NODE_CASE(WindowFunc);
NODE_CASE(SubscriptingRef);
NODE_CASE(FuncExpr);
NODE_CASE(NamedArgExpr);
NODE_CASE(OpExpr);
NODE_CASE(DistinctExpr);
NODE_CASE(NullIfExpr);
NODE_CASE(ScalarArrayOpExpr);
NODE_CASE(BoolExpr);
NODE_CASE(SubLink);
NODE_CASE(SubPlan);
NODE_CASE(AlternativeSubPlan);
NODE_CASE(FieldSelect);
NODE_CASE(FieldStore);
NODE_CASE(RelabelType);
NODE_CASE(CoerceViaIO);
NODE_CASE(ArrayCoerceExpr);
NODE_CASE(ConvertRowtypeExpr);
NODE_CASE(CollateExpr);
NODE_CASE(CaseExpr);
NODE_CASE(CaseWhen);
NODE_CASE(CaseTestExpr);
NODE_CASE(ArrayExpr);
NODE_CASE(RowExpr);
NODE_CASE(RowCompareExpr);
NODE_CASE(CoalesceExpr);
NODE_CASE(MinMaxExpr);
NODE_CASE(SQLValueFunction);
NODE_CASE(XmlExpr);
NODE_CASE(NullTest);
NODE_CASE(BooleanTest);
NODE_CASE(CoerceToDomain);
NODE_CASE(CoerceToDomainValue);
NODE_CASE(SetToDefault);
NODE_CASE(CurrentOfExpr);
NODE_CASE(NextValueExpr);
NODE_CASE(InferenceElem);
NODE_CASE(TargetEntry);
NODE_CASE(RangeTblRef);
NODE_CASE(JoinExpr);
NODE_CASE(FromExpr);
NODE_CASE(OnConflictExpr);
/*
* plan nodes (plannodes.h)
*/