postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-16 02:23:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix missing upgrade/downgrade tests DDL validation

Browse Source 
Recently we fixed a DDL error (#4739) after upgrading to 2.8.0 version
that surprisly the CI upgrade/dowgrade tests didn't complained during
the development of the feature (#4552).

Fixed it by adding an specific query in the `post.catalog.sql` script to
make sure we'll check all the constraints of our internal tables and
catalog.
This commit is contained in:
Fabrízio de Royes Mello 2022-09-22 18:29:36 -03:00
parent 2f739bb328
commit e0bbd4042a
2 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
scripts/test_downgrade_from_tag.sh
View File

@ -92,14 +92,14 @@ docker_pgcmd() {
docker_pgscript() { docker_pgscript() {
local database=${3:-single} local database=${3:-single}
docker_exec $1 "psql -h localhost -U postgres -d $database $PGOPTS -v ON_ERROR_STOP=1 -f $2" docker_exec $1 "psql --set VERBOSITY=verbose --set ECHO=all -h localhost -U postgres -d $database $PGOPTS -v ON_ERROR_STOP=1 -f $2"
} }
docker_pgtest() { docker_pgtest() {
local database=${3:-single} local database=${3:-single}
set +e set +e
>&2 echo -e "\033[1m$1\033[0m: $2" >&2 echo -e "\033[1m$1\033[0m: $2"
if ! docker exec $1 psql -X -v ECHO=ALL -v ON_ERROR_STOP=1 -h localhost -U postgres -d $database -f $2 > ${TEST_TMPDIR}/$1.out if ! docker exec $1 psql -X -v ECHO=ALL -v ON_ERROR_STOP=1 -h localhost -U postgres -d $database $PGOPTS -f $2 > ${TEST_TMPDIR}/$1.out
then then
docker_logs $1 docker_logs $1
exit 1 exit 1

15
test/sql/updates/post.catalog.sql
View File

@ -27,9 +27,9 @@ WHERE classoid = 'pg_class'::regclass
ORDER BY schema, name, initpriv; ORDER BY schema, name, initpriv;
\di _timescaledb_catalog.* \di _timescaledb_catalog.*
\ds+ _timescaledb_catalog.*; \ds+ _timescaledb_catalog.*
\df _timescaledb_internal.*; \df _timescaledb_internal.*
\df+ _timescaledb_internal.*; \df+ _timescaledb_internal.*
\df public.*; \df public.*;
\df+ public.*; \df+ public.*;
@ -43,9 +43,7 @@ SELECT count(*)
AND refobjid = (SELECT oid FROM pg_extension WHERE extname = 'timescaledb'); AND refobjid = (SELECT oid FROM pg_extension WHERE extname = 'timescaledb');
-- The list of tables configured to be dumped. -- The list of tables configured to be dumped.
SELECT obj::regclass::text SELECT unnest(extconfig)::regclass::text AS obj FROM pg_extension WHERE extname='timescaledb' ORDER BY 1;
FROM (SELECT unnest(extconfig) AS obj FROM pg_extension WHERE extname='timescaledb') AS objects
ORDER BY obj::regclass::text;
-- Show dropped chunks -- Show dropped chunks
SELECT * SELECT *
@ -75,3 +73,8 @@ FROM pg_depend dep
WHERE classid='pg_class'::regclass WHERE classid='pg_class'::regclass
ORDER BY attrelid::regclass::text,att.attnum; ORDER BY attrelid::regclass::text,att.attnum;
-- Show constraints
SELECT conrelid::regclass::text, conname, pg_get_constraintdef(oid)
FROM pg_constraint
WHERE conrelid::regclass::text ~ '^_timescaledb_'
ORDER BY 1, 2, 3;