postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-04-20 03:21:15 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improve regression test script to cleanup more thoroughly

Browse Source 
Using the regression test script on a remote machine would leave
behind a secondary database (by default called `single_2`) that
would cause the next run to fail when trying to remove the role
that owned the secondary database. This change has the script
remove the secondary database so that no longer happens.
This commit is contained in:
Rob Kiefer 2018-08-27 17:30:35 +02:00 committed by RobAtticus
parent fc3677f7fa
commit d1710efde5
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/runner.sh
View File

@ -27,9 +27,18 @@ TEST_ROLE_DEFAULT_PERM_USER_2=${TEST_ROLE_DEFAULT_PERM_USER_2:-default_perm_user
shift
# Keep original args around to use in cleanup
ORIG_ARGS=("$@")
function cleanup {
rm -rf ${TEST_TABLESPACE1_PATH}
rm -rf ${TEST_TABLESPACE2_PATH}
# When testing remotely, the secondary database does not get removed, so
# remove it directly because it causes problems when trying to drop super
# user roles on next run (i.e., the db is a dependency of the role).
# Problem is not noticed when using `make installcheck` because it makes a
# new instance each time.
${PSQL} ${ORIG_ARGS} -U ${USER} -d postgres -v ECHO=none -c "DROP DATABASE IF EXISTS ${TEST_DBNAME2};" > /dev/null 2>&1 || :
}
trap cleanup EXIT