postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-15 18:13:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix sanitizer error by removing an invalid test

Browse Source 
The problem with the test in compression_unti_test.c was that
tsl_bool_compressor_finish() expects a BoolCompressor and it
should get it from its pair: tsl_bool_compressor_append().

The test supplied an incompatible type (ExtendedCompressor)
coming from bool_compressor_for_type() and sanitizer caught it.

Disable-check: force-changelog-file
This commit is contained in:
David Beck 2025-02-18 14:33:34 +00:00 committed by David Beck
parent 0db119d41b
commit c19f09b831
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tsl/test/src/compression_unit_test.c
View File

@ -738,6 +738,7 @@ test_bool_array(bool nulls, int run_length, int expected_size)
static void
test_empty_bool_compressor()
{
/* This returns an ExtendedCompressor from bool_compress.c */
Compressor *compressor = bool_compressor_for_type(BOOLOID);
Datum compressed = (Datum) compressor->finish(compressor);
TestAssertTrue(DatumGetPointer(compressed) == NULL);
@ -746,14 +747,12 @@ test_empty_bool_compressor()
compressed = (Datum) compressor->finish(NULL);
TestAssertTrue(DatumGetPointer(compressed) == NULL);
/* passing an empty compressor returns NULL */
TestEnsureError(DirectFunctionCall1(tsl_bool_compressor_finish, PointerGetDatum(compressor)));
/* passing a NULL pointer returns NULL */
TestEnsureError(DirectFunctionCall1(tsl_bool_compressor_finish, PointerGetDatum(NULL)));
/* make codecov happy */
TestAssertTrue(bool_compressor_finish(NULL) == NULL);
/* Passing a NULL pointer returns NULL. */
TestEnsureError(DirectFunctionCall1(tsl_bool_compressor_finish, PointerGetDatum(NULL)));
TestEnsureError(bool_compressor_for_type(FLOAT4OID));
bool old_val = ts_guc_enable_bool_compression;