postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-14 17:43:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

Simplify extension tap test

Browse Source 
The extension tap test is very flakey and seems to fail very often
with unhelpful error messages. This patch simplifies the test to
make it more reliable.
This commit is contained in:
Sven Klemm 2023-09-19 13:59:00 +02:00 committed by Sven Klemm
parent 8fac069be3
commit bb11d18b59
1 changed files with 9 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
test/t/001_extension.pl
View File

@ -30,23 +30,13 @@ sub check_extension_state
# report test failures from caller location # report test failures from caller location
local $Test::Builder::Level = $Test::Builder::Level + 1; local $Test::Builder::Level = $Test::Builder::Level + 1;
# reset output collector my $result = $node->safe_psql(
$out = ""; 'postgres',
# restart per-command timer q{
$timer->start(5); SELECT * FROM extension_state();
# send the data to be sent });
$in .= "SELECT * FROM extension_state();\n";
# wait ...
pump $h until ($out =~ $pattern || $timer->is_expired); is($result, $pattern, $annotation);
my $okay = ($out =~ $pattern && !$timer->is_expired);
ok($okay, $annotation);
# for debugging, log actual output if it didn't match
local $Data::Dumper::Terse = 1;
local $Data::Dumper::Useqq = 1;
diag 'Actual output was ' . Dumper($out) . "Did not match \"$pattern\"\n"
if !$okay;
return;
} }
# Create extension_state function and check initial state # Create extension_state function and check initial state
@ -59,7 +49,7 @@ my $result = $node->safe_psql(
# Initially, the state should be "created" in both sessions # Initially, the state should be "created" in both sessions
is($result, qq/created/, "initial state is \"created\""); is($result, qq/created/, "initial state is \"created\"");
check_extension_state(qr/created/, "initial state is \"created\""); check_extension_state(qq/created/, "initial state is \"created\"");
# Drop the extension in one session, and the new state should be # Drop the extension in one session, and the new state should be
# reflected in the other backend. # reflected in the other backend.
@ -72,7 +62,7 @@ $result = $node->safe_psql(
# After dropping the extension, the new state in both sessions should # After dropping the extension, the new state in both sessions should
# be "unknown" # be "unknown"
is($result, qq/unknown/, "state after dropped is \"unknown\""); is($result, qq/unknown/, "state after dropped is \"unknown\"");
check_extension_state(qr/unknown/, check_extension_state(qq/unknown/,
"state is \"unknown\" after extension is dropped in other backend"); "state is \"unknown\" after extension is dropped in other backend");
# Create the extension again, which should be reflected in both # Create the extension again, which should be reflected in both
@ -86,7 +76,7 @@ $result = $node->safe_psql(
# After creating the extension again in one session, the other session # After creating the extension again in one session, the other session
# should go back to "created" state. # should go back to "created" state.
is($result, qq/created/, "state after creating extension is \"created\""); is($result, qq/created/, "state after creating extension is \"created\"");
check_extension_state(qr/created/, check_extension_state(qq/created/,
"state is \"created\" after extension is created in other backend"); "state is \"created\" after extension is created in other backend");
# Quit the interactive psql session # Quit the interactive psql session