postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-17 11:03:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use function oids instead of names when transforming the sort keys

Browse Source 
This is more explicit, and looking up the function name each time has a
performance impact.
This commit is contained in:
Alexander Kuzmenkov 2021-12-10 17:26:09 +03:00 committed by Alexander Kuzmenkov
parent 519e5de21c
commit babcc8e9ee
1 changed files with 21 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/sort_transform.c
View File

@ -8,12 +8,14 @@
#include <nodes/makefuncs.h> #include <nodes/makefuncs.h>
#include <nodes/nodeFuncs.h> #include <nodes/nodeFuncs.h>
#include <nodes/plannodes.h> #include <nodes/plannodes.h>
#include <parser/parsetree.h>
#include <utils/guc.h>
#include <optimizer/planner.h>
#include <optimizer/paths.h> #include <optimizer/paths.h>
#include <optimizer/planner.h>
#include <parser/parsetree.h>
#include <utils/fmgroids.h>
#include <utils/guc.h>
#include <utils/lsyscache.h> #include <utils/lsyscache.h>
#include "compat/compat.h"
#include "func_cache.h" #include "func_cache.h"
#include "sort_transform.h" #include "sort_transform.h"
@ -195,7 +197,6 @@ ts_sort_transform_expr(Expr *orig_expr)
if (IsA(orig_expr, FuncExpr)) if (IsA(orig_expr, FuncExpr))
{ {
FuncExpr *func = (FuncExpr *) orig_expr; FuncExpr *func = (FuncExpr *) orig_expr;
char *func_name = get_func_name(func->funcid);
FuncInfo *finfo = ts_func_cache_get_bucketing_func(func->funcid); FuncInfo *finfo = ts_func_cache_get_bucketing_func(func->funcid);
if (NULL != finfo) if (NULL != finfo)
@ -206,10 +207,24 @@ ts_sort_transform_expr(Expr *orig_expr)
return finfo->sort_transform(func); return finfo->sort_transform(func);
} }
if (strncmp(func_name, "timestamp", NAMEDATALEN) == 0) /* Functions of one argument that convert something to timestamp(tz). */
#if PG14_LT
if (func->funcid == F_DATE_TIMESTAMP || func->funcid == F_TIMESTAMPTZ_TIMESTAMP)
#else
if (func->funcid == F_TIMESTAMP_DATE || func->funcid == F_TIMESTAMP_TIMESTAMPTZ)
#endif
{
return transform_timestamp_cast(func); return transform_timestamp_cast(func);
if (strncmp(func_name, "timestamptz", NAMEDATALEN) == 0) }
#if PG14_LT
if (func->funcid == F_DATE_TIMESTAMPTZ || func->funcid == F_TIMESTAMP_TIMESTAMPTZ)
#else
if (func->funcid == F_TIMESTAMPTZ_DATE || func->funcid == F_TIMESTAMPTZ_TIMESTAMP)
#endif
{
return transform_timestamptz_cast(func); return transform_timestamptz_cast(func);
}
} }
if (IsA(orig_expr, OpExpr)) if (IsA(orig_expr, OpExpr))
{ {