postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-17 11:03:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Require superuser for BGW start/stop/restart

Browse Source 
Start requiring superuser privileges to start/stop/restart
background workers.
This commit is contained in:
Matvey Arye 2019-06-19 15:22:53 -04:00 committed by Matvey Arye
parent e049238a07
commit afdb3269a8
3 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/loader/bgw_interface.c
View File

@ -61,17 +61,32 @@ ts_bgw_num_unreserved(PG_FUNCTION_ARGS)
Datum Datum
ts_bgw_db_workers_start(PG_FUNCTION_ARGS) ts_bgw_db_workers_start(PG_FUNCTION_ARGS)
{ {
if (!superuser())
ereport(ERROR,
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
(errmsg("must be superuser to start background workers"))));
PG_RETURN_BOOL(ts_bgw_message_send_and_wait(START, MyDatabaseId)); PG_RETURN_BOOL(ts_bgw_message_send_and_wait(START, MyDatabaseId));
} }
Datum Datum
ts_bgw_db_workers_stop(PG_FUNCTION_ARGS) ts_bgw_db_workers_stop(PG_FUNCTION_ARGS)
{ {
if (!superuser())
ereport(ERROR,
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
(errmsg("must be superuser to stop background workers"))));
PG_RETURN_BOOL(ts_bgw_message_send_and_wait(STOP, MyDatabaseId)); PG_RETURN_BOOL(ts_bgw_message_send_and_wait(STOP, MyDatabaseId));
} }
Datum Datum
ts_bgw_db_workers_restart(PG_FUNCTION_ARGS) ts_bgw_db_workers_restart(PG_FUNCTION_ARGS)
{ {
if (!superuser())
ereport(ERROR,
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
(errmsg("must be superuser to restart background workers"))));
PG_RETURN_BOOL(ts_bgw_message_send_and_wait(RESTART, MyDatabaseId)); PG_RETURN_BOOL(ts_bgw_message_send_and_wait(RESTART, MyDatabaseId));
} }

10
test/expected/bgw_db_scheduler.out
View File

@ -901,13 +901,21 @@ SELECT * FROM sorted_bgw_log;
-- Test updating jobs list -- Test updating jobs list
TRUNCATE bgw_log; TRUNCATE bgw_log;
\set ON_ERROR_STOP 0
SELECT _timescaledb_internal.stop_background_workers();
ERROR: must be superuser to stop background workers
SELECT _timescaledb_internal.restart_background_workers();
ERROR: must be superuser to restart background workers
SELECT _timescaledb_internal.start_background_workers();
ERROR: must be superuser to start background workers
\set ON_ERROR_STOP 1
\c :TEST_DBNAME :ROLE_SUPERUSER
SELECT _timescaledb_internal.stop_background_workers(); SELECT _timescaledb_internal.stop_background_workers();
stop_background_workers stop_background_workers
------------------------- -------------------------
t t
(1 row) (1 row)
\c :TEST_DBNAME :ROLE_SUPERUSER
CREATE OR REPLACE FUNCTION ts_test_job_refresh() RETURNS TABLE( CREATE OR REPLACE FUNCTION ts_test_job_refresh() RETURNS TABLE(
id INTEGER, id INTEGER,
application_name NAME, application_name NAME,

7
test/sql/bgw_db_scheduler.sql
View File

@ -381,9 +381,16 @@ SELECT * FROM sorted_bgw_log;
-- Test updating jobs list -- Test updating jobs list
TRUNCATE bgw_log; TRUNCATE bgw_log;
\set ON_ERROR_STOP 0
SELECT _timescaledb_internal.stop_background_workers(); SELECT _timescaledb_internal.stop_background_workers();
SELECT _timescaledb_internal.restart_background_workers();
SELECT _timescaledb_internal.start_background_workers();
\set ON_ERROR_STOP 1
\c :TEST_DBNAME :ROLE_SUPERUSER \c :TEST_DBNAME :ROLE_SUPERUSER
SELECT _timescaledb_internal.stop_background_workers();
CREATE OR REPLACE FUNCTION ts_test_job_refresh() RETURNS TABLE( CREATE OR REPLACE FUNCTION ts_test_job_refresh() RETURNS TABLE(
id INTEGER, id INTEGER,
application_name NAME, application_name NAME,