postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-20 04:35:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory overflow

Browse Source 
Fix heap buffer overflow when renaming compressed hypertable columns.
This commit is contained in:
Markos Fountoulakis 2021-06-23 10:44:15 +03:00 committed by Markos Fountoulakis
parent c82b5c3262
commit a5caa5562f
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/hypertable_compression.c
View File

@ -4,6 +4,7 @@
* LICENSE-APACHE for a copy of the license. * LICENSE-APACHE for a copy of the license.
*/ */
#include <postgres.h> #include <postgres.h>
#include <utils/builtins.h>
#include "hypertable.h" #include "hypertable.h"
#include "hypertable_cache.h" #include "hypertable_cache.h"
@ -175,6 +176,7 @@ ts_hypertable_compression_rename_column(int32 htid, char *old_column_name, char
ts_scanner_foreach(&iterator) ts_scanner_foreach(&iterator)
{ {
NameData name_new_column_name;
bool isnull; bool isnull;
TupleInfo *ti = ts_scan_iterator_tuple_info(&iterator); TupleInfo *ti = ts_scan_iterator_tuple_info(&iterator);
Datum datum = slot_getattr(ti->slot, Anum_hypertable_compression_attname, &isnull); Datum datum = slot_getattr(ti->slot, Anum_hypertable_compression_attname, &isnull);
@ -191,8 +193,9 @@ ts_hypertable_compression_rename_column(int32 htid, char *old_column_name, char
tuple = ts_scanner_fetch_heap_tuple(ti, false, &should_free); tuple = ts_scanner_fetch_heap_tuple(ti, false, &should_free);
heap_deform_tuple(tuple, tupdesc, values, isnulls); heap_deform_tuple(tuple, tupdesc, values, isnulls);
namestrcpy(&name_new_column_name, new_column_name);
values[AttrNumberGetAttrOffset(Anum_hypertable_compression_attname)] = values[AttrNumberGetAttrOffset(Anum_hypertable_compression_attname)] =
CStringGetDatum(new_column_name); NameGetDatum(&name_new_column_name);
repl[AttrNumberGetAttrOffset(Anum_hypertable_compression_attname)] = true; repl[AttrNumberGetAttrOffset(Anum_hypertable_compression_attname)] = true;
new_tuple = heap_modify_tuple(tuple, tupdesc, values, isnulls, repl); new_tuple = heap_modify_tuple(tuple, tupdesc, values, isnulls, repl);
ts_catalog_update(ti->scanrel, new_tuple); ts_catalog_update(ti->scanrel, new_tuple);