From 887f538cd7dd9330f9b1ea87f14d4561d0966610 Mon Sep 17 00:00:00 2001 From: gayyappan Date: Thu, 21 Sep 2023 11:04:08 -0400 Subject: [PATCH] Fix error in osmcallback hook The callback hook should use the old pointer instead of the new. This causes a segfault when ptr is NULL. --- .unreleased/PR_6106 | 1 + src/osm_callbacks.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 .unreleased/PR_6106 diff --git a/.unreleased/PR_6106 b/.unreleased/PR_6106 new file mode 100644 index 000000000..2f19ebe3c --- /dev/null +++ b/.unreleased/PR_6106 @@ -0,0 +1 @@ +Fixes: #6106 incorrect pointer usage in OSM hook callback diff --git a/src/osm_callbacks.c b/src/osm_callbacks.c index c072ad237..90ad76c5d 100644 --- a/src/osm_callbacks.c +++ b/src/osm_callbacks.c @@ -61,7 +61,7 @@ ts_get_osm_hypertable_drop_hook() { OsmCallbacks *ptr_old = ts_get_osm_callbacks_old(); if (ptr_old) - return ptr->hypertable_drop_hook; + return ptr_old->hypertable_drop_hook; } return NULL; }