postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-17 19:13:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Schema qualify UDTs in multi-node

Browse Source 
"create_distributed_hypertable" fails on the datanodes if the columns
involved in the underlying non-default schema-qualified PG table are
using user defined types (UDTs) from another non-standard schema.

This happens because we explicitly set the namespace during the table
creation on the datanode which doesn't allow us to lookup other
schemas. We now unconditionally schema-qualify the UDT while sending
the SQL from access node to the datanode to avoid this.

Includes test case changes.

Issue reported by and general fix provided by @phemmer

Fixes #3543
This commit is contained in:
Nikhil 2021-09-30 15:00:19 +05:30 committed by Nikhils
parent f0ba729acb
commit 7570f27638
2 changed files with 36 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tsl/src/deparse.c
View File

@ -170,14 +170,22 @@ deparse_columns(StringInfo stmt, Relation rel)
{
int dim_idx;
Form_pg_attribute attr = TupleDescAttr(rel_desc, att_idx);
bits16 flags = FORMAT_TYPE_TYPEMOD_GIVEN;
if (attr->attisdropped)
continue;
/*
* if it's not a builtin type then schema qualify the same. There's a function
* deparse_type_name in fdw, but we don't want cross linking unnecessarily
*/
if (attr->atttypid >= FirstBootstrapObjectId)
flags |= FORMAT_TYPE_FORCE_QUALIFY;
appendStringInfo(stmt,
"\"%s\" %s",
NameStr(attr->attname),
format_type_with_typemod(attr->atttypid, attr->atttypmod));
format_type_extended(attr->atttypid, attr->atttypmod, flags));
if (attr->attnotnull)
appendStringInfoString(stmt, " NOT NULL");

29
tsl/test/t/001_simple_multinode.pl
View File

@ -8,10 +8,11 @@ use warnings;
use AccessNode;
use DataNode;
use TestLib;
use Test::More tests => 9;
use Test::More tests => 12;
#Initialize all the multi-node instances
my $an = AccessNode->create('an');
my $an = AccessNode->create('an');
my $dn1 = DataNode->create('dn1');
my $dn2 = DataNode->create('dn2');
@ -51,6 +52,30 @@ $dn2->psql_is(
"_timescaledb_internal._dist_hyper_1_2_chunk",
'DN2 shows correct set of chunks');
# Check that distributed tables in non-default schema and also containing user created types
# in another schema are created properly
$query = q[CREATE SCHEMA myschema];
$an->safe_psql('postgres', "$query; CALL distributed_exec('$query');");
$query =
q[CREATE TYPE public.full_address AS (city VARCHAR(90), street VARCHAR(90))];
$an->safe_psql('postgres', "$query; CALL distributed_exec('$query');");
# Create a table in the myschema schema using this unqualified UDT. Should work
$an->safe_psql('postgres',
"CREATE TABLE myschema.test (time timestamp, a full_address);");
# A distributed table creation followed by sample INSERT should succeed now
$an->safe_psql('postgres',
"SELECT create_distributed_hypertable('myschema.test', 'time');");
$an->safe_psql('postgres',
"INSERT INTO myschema.test VALUES ('2018-03-02 1:00', ('Kilimanjaro', 'Diamond St'));"
);
$an->psql_is(
'postgres',
"SELECT * from myschema.test",
q[2018-03-02 01:00:00|(Kilimanjaro,"Diamond St")],
'AN shows correct data with UDT from different schema');
done_testing();
1;