postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-19 04:03:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

Change the flaky check to use output files

Browse Source 
This is simpler, accounts for both sql and isolation tests, changes in
included files, and versioned tests.
This commit is contained in:
Alexander Kuzmenkov 2022-11-09 19:59:15 +04:00 committed by Alexander Kuzmenkov
parent e4ba2bcf56
commit 6ad28248f3
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
.github/gh_matrix_builder.py vendored
View File

@ -230,9 +230,11 @@ if event_type != "pull_request":
) )
else: else:
# Check if we need to check for the flaky tests. Determine which test files # Check if we need to check for the flaky tests. Determine which test files
# have been changed in the PR. # have been changed in the PR. The sql files might include other files that
# change independently, and might be .in templates, so it's easier to look
# at the output files. They are also the same for the isolation tests.
p = subprocess.Popen( p = subprocess.Popen(
f"git diff --name-only {sys.argv[2]} -- '**test/sql/*.sql' '**test/sql/*.sql.in'", f"git diff --name-only {sys.argv[2]} -- '**expected/*.out'",
stdout=subprocess.PIPE, stdout=subprocess.PIPE,
shell=True, shell=True,
) )
@ -244,7 +246,7 @@ else:
file=sys.stderr, file=sys.stderr,
) )
sys.exit(1) sys.exit(1)
tests = [] tests = set()
test_count = 1 test_count = 1
for f in output.decode().split("\n"): for f in output.decode().split("\n"):
print(f) print(f)
@ -258,20 +260,18 @@ else:
) )
print("full list:", file=sys.stderr) print("full list:", file=sys.stderr)
print(output, file=sys.stderr) print(output, file=sys.stderr)
tests = "" tests = set()
break break
basename = os.path.basename(f) basename = os.path.basename(f)
splitted = basename.split(".") splitted = basename.split(".")
name = splitted[0] name = splitted[0]
ext = splitted[-1] ext = splitted[-1]
if ext == "in": if ext == "out":
# Account for the version number. # Account for the version number.
tests.append(name + "-*") tests.add(name)
elif ext == "sql":
tests.append(name)
else: else:
# Should've been filtered out above. # Should've been filtered out above.
print(f"unknown extension '{ext}' for test file '{f}'", file=sys.stderr) print(f"unknown extension '{ext}' for test output file '{f}'", file=sys.stderr)
sys.exit(1) sys.exit(1)
if tests: if tests:
@ -279,7 +279,7 @@ else:
build_debug_config( build_debug_config(
{ {
"coverage": False, "coverage": False,
"installcheck_args": f'TESTS="{" ".join(tests * 20)}"', "installcheck_args": f'TESTS="{" ".join(list(tests) * 20)}"',
"name": "Flaky Check Debug", "name": "Flaky Check Debug",
"pg": PG14_LATEST, "pg": PG14_LATEST,
"pginstallcheck": False, "pginstallcheck": False,