postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-15 01:53:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix show_chunks on hypertable by hash

Browse Source 
Using the new hypertable API creating closed dimentions when
partitioning by hash was leading to a segfault on show_chunks.

Fixed it by checking for the closed primary dimension and erroring out
in case of using parameters `older_than` and `newer_than`.
This commit is contained in:
Fabrízio de Royes Mello 2024-05-31 17:04:45 -03:00
parent 45befd52f9
commit 4aff9b1748
1 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/chunk.c
View File

@ -2034,6 +2034,17 @@ ts_chunk_show_chunks(PG_FUNCTION_ARGS)
Assert(ht != NULL);
time_dim = hyperspace_get_open_dimension(ht->space, 0);
if (!time_dim)
time_dim = hyperspace_get_closed_dimension(ht->space, 0);
if (time_dim && IS_CLOSED_DIMENSION(time_dim) && (!PG_ARGISNULL(1) || !PG_ARGISNULL(2)))
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("cannot specify \"older_than\" or \"newer_than\" for "
"\"closed\"-like partitioning types"),
errhint("Use \"created_before\" and/or \"created_after\" which rely on the "
"chunk creation time values.")));
if (time_dim)
time_type = ts_dimension_get_partition_type(time_dim);
else
@ -2178,6 +2189,14 @@ get_chunks_in_time_range(Hypertable *ht, int64 older_than, int64 newer_than, Mem
end_strategy = (older_than == PG_INT64_MAX) ? InvalidStrategy : BTLessStrategyNumber;
time_dim = hyperspace_get_open_dimension(ht->space, 0);
if (time_dim == NULL)
time_dim = hyperspace_get_closed_dimension(ht->space, 0);
Ensure(time_dim != NULL,
"partitioning dimension not found for hypertable \"%s\".\"%s\"",
NameStr(ht->fd.schema_name),
NameStr(ht->fd.table_name));
oldcontext = MemoryContextSwitchTo(mctx);
chunks_find_all_in_range_limit(ht,
time_dim,