Fix trigger relcache handling for COPY

Previously trigger relcache entries were not always freed during
COPY commands in PG10. This PR fixes that.

Fixes #351.

src/copy.c

@@ -361,6 +361,31 @@ timescaledb_CopyFrom(CopyState cstate, Relation main_rel, List *range_table, Hyp
 	ExecResetTupleTable(estate->es_tupleTable, false);
 
 	ExecCloseIndices(resultRelInfo);
+
+#if PG10
+	/* Close any trigger target relations */
+	ExecCleanUpTriggerState(estate);
+#elif PG96
+	{
+		/*
+		 * es_trig_target_relations sometimes created in
+		 * ExecGetTriggerResultRel on chunks. During copy to regular tables,
+		 * this never happens because the ResultRelInfo always already exists
+		 * for the regular table.
+		 */
+		ListCell   *l;
+
+		foreach(l, estate->es_trig_target_relations)
+		{
+			ResultRelInfo *resultRelInfo = (ResultRelInfo *) lfirst(l);
+
+			/* Close indices and then the relation itself */
+			ExecCloseIndices(resultRelInfo);
+			heap_close(resultRelInfo->ri_RelationDesc, NoLock);
+		}
+	}
+#endif
+
 	copy_chunk_state_destroy(ccstate);
 
 	/*

test/expected/copy.out

@@ -29,16 +29,51 @@ INSERT INTO "two_Partitions"("timeCustom", device_id, series_0, series_1) VALUES
 (1257894000000000000, 'dev2', 1.5, 2);
 \set QUIET on
 \o
+--old chunks
+COPY "two_Partitions"("timeCustom", device_id, series_0, series_1) FROM STDIN DELIMITER ',';
+\copy "two_Partitions"("timeCustom", device_id, series_0, series_1) FROM STDIN DELIMITER ',';
+--new chunks
+COPY "two_Partitions"("timeCustom", device_id, series_0, series_1) FROM STDIN DELIMITER ',';
+\copy "two_Partitions"("timeCustom", device_id, series_0, series_1) FROM STDIN DELIMITER ',';
 COPY (SELECT * FROM "two_Partitions" ORDER BY "timeCustom", device_id) TO STDOUT;
+1257894000000000000	 dev-copy	1.5	2	\N	\N
+1257894000000000000	 dev-copy	1.5	2	\N	\N
 1257894000000000000	dev1	1.5	1	2	t
 1257894000000000000	dev1	1.5	2	\N	\N
-1257894000000000000	dev2	1.5	2	\N	\N
 1257894000000000000	dev2	1.5	1	\N	\N
+1257894000000000000	dev2	1.5	2	\N	\N
 1257894000000001000	dev1	2.5	3	\N	\N
 1257894001000000000	dev1	3.5	4	\N	\N
 1257894002000000000	dev1	2.5	3	\N	\N
 1257894002000000000	dev1	5.5	6	\N	t
 1257894002000000000	dev1	5.5	7	\N	f
 1257897600000000000	dev1	4.5	5	\N	f
-1257987600000000000	dev1	1.5	2	\N	\N
 1257987600000000000	dev1	1.5	1	\N	\N
+1257987600000000000	dev1	1.5	2	\N	\N
+2257894000000000000	 dev-copy	1.5	2	\N	\N
+2257894000000000000	 dev-copy	1.5	2	\N	\N
+---test hypertable with FK
+CREATE TABLE "meta" ("id" serial PRIMARY KEY);
+CREATE TABLE "hyper" (
+    "meta_id" integer NOT NULL REFERENCES meta(id),
+    "time" bigint NOT NULL,
+    "value" double precision NOT NULL
+);
+SELECT create_hypertable('hyper', 'time', chunk_time_interval => 100);
+ create_hypertable 
+-------------------
+ 
+(1 row)
+
+INSERT INTO "meta" ("id") values (1);
+\copy hyper (time, meta_id, value) FROM STDIN DELIMITER ',';
+COPY hyper (time, meta_id, value) FROM STDIN DELIMITER ',';
+\set ON_ERROR_STOP 0
+\copy hyper (time, meta_id, value) FROM STDIN DELIMITER ',';
+ERROR:  insert or update on table "_hyper_2_6_chunk" violates foreign key constraint "6_1_hyper_meta_id_fkey"
+COPY hyper (time, meta_id, value) FROM STDIN DELIMITER ',';
+ERROR:  insert or update on table "_hyper_2_6_chunk" violates foreign key constraint "6_1_hyper_meta_id_fkey"
+\set ON_ERROR_STOP 1
+COPY (SELECT * FROM hyper ORDER BY time, meta_id) TO STDOUT;
+1	1	1
+1	2	1

test/sql/CMakeLists.txt

@@ -8,7 +8,7 @@ set(TEST_FILES
   chunks.sql
   cluster.sql
   constraint.sql
-  copy_from.sql
+  copy.sql
   create_chunks.sql
   create_hypertable.sql
   create_table.sql

test/sql/copy.sql

@@ -0,0 +1,51 @@
+\o /dev/null
+\ir include/insert_two_partitions.sql
+\o
+
+--old chunks
+COPY "two_Partitions"("timeCustom", device_id, series_0, series_1) FROM STDIN DELIMITER ',';
+1257894000000000000, dev-copy, 1.5, 2
+\.
+\copy "two_Partitions"("timeCustom", device_id, series_0, series_1) FROM STDIN DELIMITER ',';
+1257894000000000000, dev-copy, 1.5, 2
+\.
+
+--new chunks
+COPY "two_Partitions"("timeCustom", device_id, series_0, series_1) FROM STDIN DELIMITER ',';
+2257894000000000000, dev-copy, 1.5, 2
+\.
+\copy "two_Partitions"("timeCustom", device_id, series_0, series_1) FROM STDIN DELIMITER ',';
+2257894000000000000, dev-copy, 1.5, 2
+\.
+
+COPY (SELECT * FROM "two_Partitions" ORDER BY "timeCustom", device_id) TO STDOUT;
+
+
+---test hypertable with FK
+CREATE TABLE "meta" ("id" serial PRIMARY KEY);
+CREATE TABLE "hyper" (
+    "meta_id" integer NOT NULL REFERENCES meta(id),
+    "time" bigint NOT NULL,
+    "value" double precision NOT NULL
+);
+SELECT create_hypertable('hyper', 'time', chunk_time_interval => 100);
+
+INSERT INTO "meta" ("id") values (1);
+\copy hyper (time, meta_id, value) FROM STDIN DELIMITER ',';
+1,1,1
+\.
+
+COPY hyper (time, meta_id, value) FROM STDIN DELIMITER ',';
+2,1,1
+\.
+
+\set ON_ERROR_STOP 0
+\copy hyper (time, meta_id, value) FROM STDIN DELIMITER ',';
+1,2,1
+\.
+COPY hyper (time, meta_id, value) FROM STDIN DELIMITER ',';
+2,2,1
+\.
+\set ON_ERROR_STOP 1
+
+COPY (SELECT * FROM hyper ORDER BY time, meta_id) TO STDOUT;

test/sql/copy_from.sql

@@ -1,7 +0,0 @@
-\o /dev/null
-\ir include/insert_two_partitions.sql
-\o
-
-COPY (SELECT * FROM "two_Partitions" ORDER BY "timeCustom", device_id) TO STDOUT;
-
-