postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-21 21:21:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix recompression ignoring partial compressed chunks

Browse Source 
The recompression policy only recompresses unordered chunks which
will be rarely created but does not deal with partial chunks which
are the result of DML operations into compressed chunks.
This commit is contained in:
Sven Klemm 2024-02-02 08:33:48 +01:00 committed by Sven Klemm
parent 9e737bc528
commit 435658524c
7 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.unreleased/pr_6592 Normal file
View File

@ -0,0 +1 @@
Fixes: #6592 Fix recompression policy ignoring partially compressed chunks

4
tsl/src/bgw_policy/job.c
View File

@ -509,8 +509,10 @@ policy_recompression_execute(int32 job_id, Jsonb *config)
StartTransactionCommand();
int32 chunkid = lfirst_int(lc);
Chunk *chunk = ts_chunk_get_by_id(chunkid, true);
if (!chunk || !ts_chunk_is_unordered(chunk))
Assert(chunk);
if (!ts_chunk_is_unordered(chunk) && !ts_chunk_is_partial(chunk))
continue;
tsl_recompress_chunk_wrapper(chunk);
elog(LOG,

2
tsl/src/compression/api.c
View File

@ -817,7 +817,7 @@ tsl_recompress_chunk_wrapper(Chunk *uncompressed_chunk)
{
Oid uncompressed_chunk_relid = uncompressed_chunk->table_id;
if (ts_chunk_is_unordered(uncompressed_chunk))
if (ts_chunk_is_compressed(uncompressed_chunk))
{
if (!decompress_chunk_impl(uncompressed_chunk->hypertable_relid,
uncompressed_chunk_relid,

2
tsl/test/expected/compression_bgw-13.out
View File

@ -646,7 +646,7 @@ CALL run_job(:JOB_RECOMPRESS);
SELECT chunk_status FROM compressed_chunk_info_view WHERE hypertable_name = 'metrics';
chunk_status
--------------
9
1
(1 row)
SELECT delete_job(:JOB_RECOMPRESS);

2
tsl/test/expected/compression_bgw-14.out
View File

@ -646,7 +646,7 @@ CALL run_job(:JOB_RECOMPRESS);
SELECT chunk_status FROM compressed_chunk_info_view WHERE hypertable_name = 'metrics';
chunk_status
--------------
9
1
(1 row)
SELECT delete_job(:JOB_RECOMPRESS);

2
tsl/test/expected/compression_bgw-15.out
View File

@ -646,7 +646,7 @@ CALL run_job(:JOB_RECOMPRESS);
SELECT chunk_status FROM compressed_chunk_info_view WHERE hypertable_name = 'metrics';
chunk_status
--------------
9
1
(1 row)
SELECT delete_job(:JOB_RECOMPRESS);

2
tsl/test/expected/compression_bgw-16.out
View File

@ -646,7 +646,7 @@ CALL run_job(:JOB_RECOMPRESS);
SELECT chunk_status FROM compressed_chunk_info_view WHERE hypertable_name = 'metrics';
chunk_status
--------------
9
1
(1 row)
SELECT delete_job(:JOB_RECOMPRESS);