postgres/timescaledb
1
0
Fork 0
mirror of https://github.com/timescale/timescaledb.git synced 2025-05-15 18:13:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove test case causing bgw_custom crash

Browse Source 
Patch #4425 introduced regression test failures, namely, a crash
in function `ts_bgw_job_update_by_id`. The failures are due to the
COMMIT statement in the custom check procedure. This patch removes
that particular test case from bgw_custom.
This commit is contained in:
Konstantina Skovola 2022-09-12 14:44:38 +03:00 committed by Konstantina Skovola
parent 0144c75b3f
commit 3b3681858d
2 changed files with 0 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tsl/test/expected/bgw_custom.out
View File

@ -827,27 +827,6 @@ select alter_job(:job_id_alter, config => '{}');
(1011,"@ 5 secs","@ 0",-1,"@ 5 mins",t,{},-infinity,)
(1 row)
-- test what happens if the check function contains a COMMIT
-- procedure with transaction handling
CREATE OR REPLACE PROCEDURE custom_proc2_jsonb(config jsonb) LANGUAGE PLPGSQL AS
$$
BEGIN
-- RAISE NOTICE 'Starting some transactions inside procedure';
INSERT INTO custom_log VALUES(1, $1, 'custom_proc 1 COMMIT');
COMMIT;
END
$$;
select add_job('test_proc_with_check', '5 secs', config => '{}') as job_id_err \gset
select alter_job(:job_id_err, check_config => 'custom_proc2_jsonb');
ERROR: portal snapshots (0) did not account for all active snapshots (1)
select alter_job(:job_id_err, schedule_interval => '3 minutes');
alter_job
-------------------------------------------------------
(1012,"@ 3 mins","@ 0",-1,"@ 5 mins",t,{},-infinity,)
(1 row)
select add_job('test_proc_with_check', '5 secs', config => '{}', check_config => 'custom_proc2_jsonb') as job_id_commit \gset
ERROR: portal snapshots (0) did not account for all active snapshots (1)
-- test the case where we have a background job that registers jobs with a check fn
CREATE OR REPLACE PROCEDURE add_scheduled_jobs_with_check(job_id int, config jsonb) LANGUAGE PLPGSQL AS
$$

16
tsl/test/sql/bgw_custom.sql
View File

@ -499,22 +499,6 @@ select alter_job(:job_id_alter, check_config => 0);
-- no message printed now
select alter_job(:job_id_alter, config => '{}');
-- test what happens if the check function contains a COMMIT
-- procedure with transaction handling
CREATE OR REPLACE PROCEDURE custom_proc2_jsonb(config jsonb) LANGUAGE PLPGSQL AS
$$
BEGIN
-- RAISE NOTICE 'Starting some transactions inside procedure';
INSERT INTO custom_log VALUES(1, $1, 'custom_proc 1 COMMIT');
COMMIT;
END
$$;
select add_job('test_proc_with_check', '5 secs', config => '{}') as job_id_err \gset
select alter_job(:job_id_err, check_config => 'custom_proc2_jsonb');
select alter_job(:job_id_err, schedule_interval => '3 minutes');
select add_job('test_proc_with_check', '5 secs', config => '{}', check_config => 'custom_proc2_jsonb') as job_id_commit \gset
-- test the case where we have a background job that registers jobs with a check fn
CREATE OR REPLACE PROCEDURE add_scheduled_jobs_with_check(job_id int, config jsonb) LANGUAGE PLPGSQL AS
$$